use ansys-api-mapdl-v0 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
approved these changes
Oct 29, 2021
| @@ -155,8 +154,8 @@ def test_license_type_keyword_names(): | |||
| # This test might became a way to check available licenses, which is not the purpose. | |||
|
|
|||
| successful_check = False | |||
| for license_description, each_keyword in zip(LICENSES.values(), keywords): | |||
| mapdl = launch_mapdl(license_type=each_keyword) | |||
| for license_name, license_description in LICENSES.items(): | |||
There was a problem hiding this comment.
I don't know how did I write this.
There was a problem hiding this comment.
It's ok, this isn't checked in our online CI/CD and I only discovered this when running tests locally. Another reason to have a windows/linux standalone package of MAPDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PyMAPDL to use the gRPC compliant-named package
ansys-api-mapdl-v0.The package has been build using
grpcio-tools=1.21.1to allow for the usage of Mechanical's CPythonprotobuf=3.8.0to resolve #649.