-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved /TBFT function. #782
Conversation
It does know upload the experimental data files.
It does know upload the experimental data files.
tests/test_mapdl.py
Outdated
fname = 'expdata0.dat' | ||
with open(fname, 'w') as fid: | ||
fid.write("""0.819139E-01 0.82788577E+00 | ||
0.166709E+00 0.15437247E+01 | ||
0.253960E+00 0.21686152E+01 | ||
0.343267E+00 0.27201819E+01 | ||
0.434257E+00 0.32129833E+0""") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the tmpdir
fixture instead of writing to the local directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmhh... I cannot use tmpdir
because that will create a file in a tmpdir, hence I would have to modify the @parametrize options, which are outside of that function. It probably can be done, but I feel like it is not worthy.
Also I want to check the option where only fname is given, hence it cannot be in a folder.
Other option is too forget the parametrize and use a more elaborated case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other option is too forget the parametrize and use a more elaborated case.
In this case it might be acceptable to create the file in the current working directory given the inflexibility of this command. What I would do instead is try...finally
. That way we'll still capture all the AssertionError
raised by our assert
statements, but always remove the file in finally
.
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
…sys/pymapdl into feat/tbft-file-improvements
…sys/pymapdl into feat/tbft-file-improvements
…sys/pymapdl into feat/tbft-file-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go. Thanks!
/TBFT
does now upload the experimental data files. Close #725