Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Richer cmd output for listing commands #816

Merged
merged 78 commits into from
Jan 11, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 10, 2022

Related to #735

Basic

It implements a class for listing command output which has three methods: to_list, to_array and to_dataframe (following Pandas convention).

Idea

It seems many of the listing commands are based in the same MAPDL fortran function, so in principle, making this CommandOutputListing class work with one of them, should make it work with all (most?) of them.

TODOs

  • Adding base class
  • Adding allowable commands
  • Adding unit tests
  • Add documentation. Cancelled in favor of a separated PR.

Dependencies

This PRs needs for #791

Testing

It will be limited to get output from the correspondent methods.

Now we detect the underlying data array based on a predefined magic word (start of data) and an empty line (end of data).
Added support to Elist and Nlist
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the lazy import. Merge as soon as checks pass.

@germa89 germa89 merged commit 93b7881 into main Jan 11, 2022
@germa89 germa89 deleted the feat/richer_cmd_output-dataframes-and-BC-list branch January 11, 2022 16:47
This was referenced Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants