Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CWD and failing tests #860

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Fixing CWD and failing tests #860

merged 3 commits into from
Jan 28, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 27, 2022

The PR #840 broke this.

This was not catch by CICD because those test do not run on CICD. Not sure why.

@germa89 germa89 added the Bug label Jan 27, 2022
@germa89 germa89 requested a review from akaszynski January 27, 2022 23:07
@germa89 germa89 self-assigned this Jan 27, 2022
@germa89
Copy link
Collaborator Author

germa89 commented Jan 27, 2022

@akaszynski why are not testing CWD in CICD? I remember we did talk about it in the past.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@406bed8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage        ?   58.08%           
=======================================
  Files           ?      172           
  Lines           ?    10560           
  Branches        ?        0           
=======================================
  Hits            ?     6134           
  Misses          ?     4426           
  Partials        ?        0           

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski akaszynski merged commit 149f99b into main Jan 28, 2022
@akaszynski akaszynski deleted the fix/return-none-in-local branch January 28, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants