Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing arguments to RESCONTROL #868

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 31, 2022

Adding missing arguments to RESCONTROL and reformatting docstring.

@germa89 germa89 added the Bug label Jan 31, 2022
@germa89 germa89 self-assigned this Jan 31, 2022
@germa89 germa89 changed the title Adding missing arguments to RESCONTROL and reformatting docstring. Adding missing arguments to RESCONTROL Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #868 (ba42fc6) into main (33ec6a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   58.27%   58.29%   +0.01%     
==========================================
  Files         172      172              
  Lines       10592    10592              
==========================================
+ Hits         6173     6175       +2     
+ Misses       4419     4417       -2     

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski
Copy link
Collaborator

BTW, you can enable auto merge so it will merge the PR as soon as checks pass now.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 31, 2022

BTW, you can enable auto merge so it will merge the PR as soon as checks pass now.

And take away the pleasure of hitting the green button?? I don't think so. ha!

Jokes apart, I will probably use it from time to time. Thank you.

@germa89 germa89 enabled auto-merge (squash) January 31, 2022 22:51
@germa89 germa89 merged commit 7a51c73 into main Jan 31, 2022
@germa89 germa89 deleted the fix/rescontrol-arguments-number branch January 31, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants