Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added split_sharp_edges and feature angle to general plotter #921

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 22, 2022

Close #920 by implementing split_sharp_edges and feature_angle

Before

No-shading

image

Shading

image

After

With split_sharp_edges = True and feature_angle = default (30)

image

With split_sharp_edges = True and feature_angle = 60

image

I dont see much difference between the angles but I made sure the keyword is passed around.

@germa89 germa89 self-assigned this Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #921 (1e16ca9) into main (efe93e3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   72.56%   72.57%           
=======================================
  Files          39       39           
  Lines        5697     5699    +2     
=======================================
+ Hits         4134     4136    +2     
  Misses       1563     1563           

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR notes.

I’m surprised dependabot didn’t bump the requirements in test requirements.

I made a minor change by allowing 0.33.0 and newer as that the minimum compatible version. It’s probably unnecessary, but figured to give people the chance should they need to use 0.33.0

@akaszynski akaszynski enabled auto-merge (squash) February 22, 2022 22:29
@akaszynski akaszynski merged commit 5ef6912 into main Feb 22, 2022
@akaszynski akaszynski deleted the feat/add-split_sharp_edges-to-general_plotter branch February 22, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add split_sharp_edges in general_plotter
2 participants