Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedding_scripts marker #662

Merged
merged 47 commits into from
Apr 11, 2024
Merged

Add embedding_scripts marker #662

merged 47 commits into from
Apr 11, 2024

Conversation

klmcadams
Copy link
Collaborator

Add embedding_scripts marker for tests that use subprocess to launch embedded apps

@github-actions github-actions bot added maintenance Package and maintenance related CI/CD dependencies Related with project dependencies enhancement New features or code improvements labels Mar 26, 2024
@klmcadams klmcadams marked this pull request as draft March 26, 2024 18:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 27, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (5286c75) to head (37c78c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   78.22%   76.85%   -1.38%     
==========================================
  Files          31       31              
  Lines        1970     1970              
==========================================
- Hits         1541     1514      -27     
- Misses        429      456      +27     

@klmcadams klmcadams marked this pull request as ready for review April 11, 2024 17:45
@klmcadams klmcadams requested a review from a team as a code owner April 11, 2024 17:45
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@klmcadams klmcadams merged commit 6fb184a into main Apr 11, 2024
56 checks passed
@klmcadams klmcadams deleted the feat/extra-marker branch April 11, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants