-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Delete the apt-get lists after installing packages #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
- Coverage 81.63% 80.85% -0.78%
==========================================
Files 32 32
Lines 1982 1980 -2
==========================================
- Hits 1618 1601 -17
- Misses 364 379 +15 |
@MaxJPRey . I think this is added to reduce the image size. Pinging @samigithub2022 for review. |
@dipinknair - @MaxJPRey's change will precisely do that, reduce the image size |
Cleaning up the apt cache and removing /var/lib/apt/lists helps keep the image size down. Since the RUN statement starts with apt-get update, the package cache will always be refreshed prior to apt-get install.
Clean up must be performed in the same RUN step, otherwise it will affect image size.