Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Delete the apt-get lists after installing packages #750

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

MaxJPRey
Copy link
Contributor

Cleaning up the apt cache and removing /var/lib/apt/lists helps keep the image size down. Since the RUN statement starts with apt-get update, the package cache will always be refreshed prior to apt-get install.

Clean up must be performed in the same RUN step, otherwise it will affect image size.

@MaxJPRey MaxJPRey requested a review from a team as a code owner May 27, 2024 14:38
@github-actions github-actions bot added CI/CD maintenance Package and maintenance related labels May 27, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 27, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (fb2512b) to head (1b0f8c9).

Current head 1b0f8c9 differs from pull request most recent head 49546e9

Please upload reports for the commit 49546e9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   81.63%   80.85%   -0.78%     
==========================================
  Files          32       32              
  Lines        1982     1980       -2     
==========================================
- Hits         1618     1601      -17     
- Misses        364      379      +15     

@dipinknair
Copy link
Collaborator

@MaxJPRey . I think this is added to reduce the image size. Pinging @samigithub2022 for review.

@RobPasMue
Copy link
Member

@dipinknair - @MaxJPRey's change will precisely do that, reduce the image size

@dipinknair dipinknair merged commit e01d03a into main Jun 3, 2024
56 checks passed
@dipinknair dipinknair deleted the maint/docker_apt branch June 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants