Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove disable sec check #776

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Fix: Remove disable sec check #776

merged 4 commits into from
Jun 18, 2024

Conversation

dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Jun 18, 2024

Removes disabling sec since it changes mechanical settings which causes issue with Background solve when using standalone Mechanical. This partially solves issue #719. This change will fix issue in Windows but not in Linux.

Test added only for windows

@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (d44a32b) to head (7c31df1).

Current head 7c31df1 differs from pull request most recent head 7deacd6

Please upload reports for the commit 7deacd6 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   81.25%   81.23%   -0.03%     
==========================================
  Files          32       32              
  Lines        2049     2046       -3     
==========================================
- Hits         1665     1662       -3     
  Misses        384      384              

@dipinknair dipinknair marked this pull request as ready for review June 18, 2024 18:42
@dipinknair dipinknair requested a review from a team as a code owner June 18, 2024 18:42
@koubaa koubaa merged commit 0fca484 into main Jun 18, 2024
56 checks passed
@koubaa koubaa deleted the fix/rsm branch June 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants