Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add background app class #849

Merged
merged 5 commits into from
Aug 6, 2024
Merged

add background app class #849

merged 5 commits into from
Aug 6, 2024

Conversation

koubaa
Copy link
Collaborator

@koubaa koubaa commented Aug 5, 2024

Mechanical isn't threadsafe, but this adds more user-friendliness to the Poster by managing a background thread, poster, and app instance in one place. This should be used in the rpyc branch

@koubaa koubaa requested a review from a team as a code owner August 5, 2024 15:36
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (999a671) to head (4957217).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   81.84%   80.71%   -1.14%     
==========================================
  Files          32       33       +1     
  Lines        2104     2157      +53     
==========================================
+ Hits         1722     1741      +19     
- Misses        382      416      +34     

@koubaa koubaa merged commit 97cb3b0 into main Aug 6, 2024
56 of 57 checks passed
@koubaa koubaa deleted the background-app branch August 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants