fix(module:datepicker): Date picker panel click closing + some issues from #1431 #1452

anddrzejb · 2021-05-02T07:33:42Z

🤔 This is a ...

🔗 Related issue link

Fixes DatePicker: The overlay panel closes when click any place #1431
Addresses parts of DatePicker: week count, date&time picker focus, quarter range & placeholder #1429 (this comment):
a. When first clicked, the RangePicker panel will first display on the left side of the page.
b. The height of the RangePicker is refreshed twice when it is opened.
When panel was opening, OnBlur event is being fired.
When Tab+Shift on RangePicker was leaving the input, it is not loosing focus.
Initial render of RangePicker if rendered above the input is placed too low when panel renedered above input element:

Closing and reopening the panel would fix that to expected behavior:

💡 Background and solution

DatePicker in OnBlur event handler was calling Close() method and should not.
a. This was an issue with Overlay manifesting only in server-side. I guess it wasn't manifesting anywhere else except RangePicker because of how complex the RangePicker is. Anyway, the issue there was that the RangePicker was starting with style set to display: inline-flex and then its position was calculated and adjusted to match input element. I changed that initial style to display: inline-flex; visibility: hidden; - we still need this to render and take space but not to be visible.
b. It wasn't really refreshing height 2 times. The problem was that when panel should hide, it receives class ant-slide-up-leave-active. That class stays there. So when it is shown again, it is made first visible with that class, and then it gets proper ant-slide-up-enter-active. So basically on any consecutive open the picker was first being animated with leave and then with enter css class. My solution is to reset the class to enter class after it is closed.
Removed Close() method call.
Missing AutoFocus = false was added.
RangePicker was supposed to get OverlayClassName="ant-picker-dropdown-range. Otherwise first render was placing the pointing arrow incorrectly. It was only affecting the panel if it was rendered above the input.

Feature: added support for Escape button - matches the behaviour of react antD.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Changelog is provided or not needed

fix: tab key behavior blur/show optimization

blur/focus optimizations

fix: flickering

github-actions · 2021-05-02T07:33:53Z

codecov-commenter · 2021-05-02T07:51:45Z

Codecov Report

Merging #1452 (b2b2463) into master (8925a63) will increase coverage by 0.00%.
The diff coverage is 6.79%.

@@           Coverage Diff           @@
##           master    #1452   +/-   ##
=======================================
  Coverage   11.32%   11.32%           
=======================================
  Files         453      453           
  Lines       28779    28826   +47     
=======================================
+ Hits         3258     3264    +6     
- Misses      25521    25562   +41

Impacted Files	Coverage Δ
components/core/Helpers/DateHelper.cs	`0.00% <0.00%> (ø)`
components/date-picker/DatePicker.Razor.cs	`0.00% <0.00%> (ø)`
components/date-picker/DatePicker.razor	`0.00% <ø> (ø)`
components/date-picker/RangePicker.razor	`0.00% <ø> (ø)`
components/date-picker/RangePicker.razor.cs	`0.00% <0.00%> (ø)`
components/date-picker/internal/DatePickerBase.cs	`0.00% <0.00%> (ø)`
...nts/date-picker/internal/DatePickerDatePanel.razor	`0.00% <0.00%> (ø)`
...date-picker/internal/DatePickerDatetimePanel.razor	`0.00% <0.00%> (ø)`
...e-picker/internal/DatePickerDatetimePanel.razor.cs	`0.00% <0.00%> (ø)`
...onents/date-picker/internal/DatePickerPanelBase.cs	`0.00% <0.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8925a63...b2b2463. Read the comment docs.

anddrzejb · 2021-05-02T18:09:40Z

@mutouzdl Could you review my commit 934acca? I was trying to push it as a new PR but for some reason cherry-pick was still picking up commit from this PR...

Commit fixes this part of #1429.

What I found was that DatePickerPanelBase.Value that was not nullable. If Value passed from DatePickerBase was null, then DateTime.Now was assumed. Changed it, so value in DatePickerPanelBase is a nullable.

Zonciu · 2021-05-02T19:34:29Z

Sorry I'm too busy recently.

anddrzejb · 2021-05-03T15:51:51Z

Commit 7ad46ed addresses issues associated with week mode:

Week picker - week count for beginning of the year is showing incorrectly. For example first week in 2020 is actually starting from the second

and it should show like this:

mutouzdl · 2021-05-06T10:09:23Z

@anddrzejb
I looked it over and found nothing wrong.

By the way, I found a problem, but this problem exists in the current version(0.8.0).
RangePicker(date mode with timer) cannot select the correct end date, nor can you select months forward.
Steps:

Choose a start date
Select an end date, and you will find that the end date is always one month longer than the selected date, and you cannot switch to the previous month

-----------translate-----------
我检测了一遍，没有问题。

顺便提一下，我发现一个问题，但这个问题在当前版本(0.8.0)中就存在了。
RangePicker（带时间的日期模式）不能选择正确的结束日期，也无法向前选择月份。

步骤：

选择一个开始日期
选择一个结束日期，此时会发现，结束日期会永远比选择的日期多1个月，并且无法切换到上一个月份

anddrzejb · 2021-05-06T10:47:07Z

@mutouzdl Thanks. Regarding the issue - I will add it to aggregated issue list #1429 we created with @Zonciu . I noticed there are several issues with RangePicker with timer, so this adds another one...

* fix(module: select): enum default value protection (#1368) * fix(module: affix): can't affix while OffsetTop is zero (#1373) * fix(module: affix): can't affix while OffsetTop is zero * use affixed setter for rerendering * limit rerendering * fix(module: input): binding data when the Enter key is pressed (#1375) * fix(module: table): ellipsis can't work (#1376) * feat: add element component (#1378) * refactor: rename `HtmlElement` property case * rename the directory name for overlay * add element component * fix(module: table): Unify FieldName, add DisplayAttribute for DiplayName, fix Filter for DataIndex (#1372) * fix(module: table): Unify FieldName value * fix(module: table): Get column name from DisplayAttribute * fix(module: table): Filter for DataIndex * docs(module: table): Intuitive sorterCompare for Filter demo * fix(module: table): fix header title doesn't display when Sortable is false Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(dialog): add Dispose lifecycle function to Dialog (#1379) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: input): preserve focus and caret position for input password when visibility is toggled (#1377) * set focus when the password button is clicked * add methods for selection * set selectionStart after Focus * fix typescript * set selectionEnd as well * fix a stupid if-condition-bug * remove checks for element * add selectionStart to getDomInfo * get selectionStart from Element * delete unneeded js method Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): can not use DataIndex nullable mode with not nullable property (#1382) * fix(module: table): column header sorter not refresh after ClearSorter is called (#1385) * fix(module:table): column header sorter not refresh after ClearSorter is called * add judgment condition for calling StateHasChanged in IFieldColumn.ClearSorter() * fix(module: form): validation message unique (#1391) * fix(module: tag): closable typo and delete mode (#1393) * fix(module: tag): closable typo and delete mode * return early * test(module: divider): divider tests (#1397) Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: modal): support define modal's style in ModalOptions (#1400) * fix(module: checkbox & switch): Checked parameter binding (#1394) * fix(module:checkbox): allow binding to Checked parameter * fix(module:switch): allow binding to Checked parameter * fix(modules): checkbox & switch get AntInputBoolComponentBase class * test(module:switch): add tests * test(module:checkbox): add tests * test(module:divider): simplify by using id:ignore * docs(module:checkbox): bind example * docs(module:switch): bind example * fix(module:switch): add Control + docs + tests * feat(module:checkboxgroup): add layout and mixed mode * fix: review comments + tests * fix(module:checkboxgroup): parameter name should be MixedMode added more tests * fix demo * fix(module:checkboxgroup): allow toggling between modes Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): OnDataSourceChange called when expected (#1419) * fix(module:select): OnDataSourceChange called when expected * test(module:select): add missing scenario * fix(module: table): DataIndex filter pop up (#1421) * fix(module:overlayTrigger): TrigerRefernece points to OverlayTrigger.Ref. * fix(module:overlay): Show waits for competing code to finish * Update OverlayTrigger.razor.cs * clean code Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat: use ResizeObserver Api instead of window.resize (#1392) * feat: use ResizeObserver Api instead of window.resize * fix(module:select): fall back to window.resize in IE11. * fix(module:domEventService): switch from IsIE11 to IsResizeObserverSupported * fix: Console.WriteLine removed Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): check null in set sorter method (#1423) * fix(module: datepicker): validate manually entered date against format (#1389) * fix(module:datepicker): validate manually entered date against format * fix(module:datepicker): keep frozen the panel until valid date entered * fix(module:datepicker): switch to current culture format * fix(module:datepicker): build fix * fix(module:datepicker): use InvariantCulture when calling ToString on date * fix(module:datepicker): FormatAnalyzer handles also year, week, month & quarter picker * fix(module:datepicker): FormatAnalyzer broken tests * fix: FormatAnalyzer handles prefixes in format. Suffix is handled for picker type = "year" Tests include validation of not changing state * fix: all modes go through format analyzing (inluding week&quarter) * fix(module:datepickerbase): InternalFormat initalized properly for all modes * fix(module:rangepicker): reset opposing date when in conflict with current * fix(module:rangePicker): handle null in second part of range * fix(module:datepicker): switch from BindConverter to partials * tests(module:datepicker): FormatAnalyzer new tests to cover switch from BindConverter * tests(module:datepicker): missed change in tests * fix: focus, key events, reset value to original if not confirmed * fix: bug fix on range & clean-up * Update DatePicker.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): issues in boundaryAdjustMode (#1420) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): incorrect size (#1432) * fix(module: cascader): incorrect size * add test for cascader size * fix(module: table): fix wrong spell for TableFilterCompareOperator.EndsWith (#1434) * fix(module: table): remove an redundant whitespace * fix(module: table): fix wrong spell * fix(module: table): fix wrong spell Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): add SelectedNodesChanged and invoke it after clear selected (#1437) * fix(module: table): fix spell mistake for TableFilterType.FieldType (#1442) * style(module:table): fix spell mistake for TableFilterType.FieldType * style(module:table): fix spell mistake for TableFilterType.FieldType * fix(module: select): fix error for nullable TItem (#1451) * fix(module: checkbox): remove Value initialization blocking (#1459) * fix(module:checkbox): remove Value initialization blocking * Update CheckboxTests.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): support IEnumerable in form (#1460) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): fix dropdown width for IE (#1469) * fix(module:select): fix dropdown width for IE * fix(module:select): add a comment to explain the change * revert 'merge local branch' * revert 'merge local branch' * revert 'merge local branch' Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: dialog): modify delay time to DOM_ MIN_ TIMEOUT_ VALUE (#1445) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: datepicker): Date picker panel click closing + some issues from #1431 (#1452) * fix(module:datetime) keep open when click on panel fix: tab key behavior blur/show optimization * fix(module:rangepicker): tab key behavior improvements blur/focus optimizations * fix(module:overlay): overlay visible before positioning fix: flickering * fix(module:datepicker): handle escape key * fix(module:datepicker): mark properly current date on panel * fix(module:datepicker): week mode calculates weeks properly * fix(module: table): exception is thrown when the DataIndex ends with the get_Item method. (#1485) * fix(module: table): set DisplayName to null if MemberExpression is not found in the DataIndex expression tree (#1488) * feat(module: cascader): support showSearch (#1484) * feat(module: cascader): support showSearch * add empty dropdown * fix clear icon * fix(module: InputNumber): input number self changing (#1490) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: inputNumber): allow culture info to format input (#1480) * fix(module:inputnumber): allow culture info to format input * docs(module:inputnumber): demo & docs * fix translation Co-authored-by: ElderJames <shunjiey@hotmail.com> * docs: update docs for modal dragging (#1497) * fix(module: table): fix built-in filter select option width (#1500) * fix(module: datepicker): fix multiple CultureInfo properties (#1492) * fix(module:datepicker): fix multiple CultureInfo properties * fix(module:datepicker): fix multiple CultureInfo properties * fix(module: input): fix Input component for Guid type (#1510) * fix(module:input): fix Input component for Guid type * docs(module:input): add Guid generic sample code * fix(module:input): add a comment to explain the change * fix(module: input): guid optimization (#1515) * fix:(module: overlay): positioning should take scroll into account (#1511) Co-authored-by: Ocoka <somewhere@network> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: js function getDom return null bug (#1417) * fix: js function getDom return null bug (#1374) * fix: add IF precompiled instruction for observer attribute Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: missing using is causing build failure (#1518) * change log 0.8.1 (#1522) * change log 0.8.1 * fix order Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: Zonciu Liang <zonciu@zonciu.com> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: MihailsKuzmins <47413092+MihailsKuzmins@users.noreply.github.com> Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: 笨木头 <musicvs@163.com> Co-authored-by: Maksim <maksalmak@gmail.com> Co-authored-by: Ivan Ocoka <ocokanet@gmail.com> Co-authored-by: Ocoka <somewhere@network>

…s from #1431 (#1452) * fix(module:datetime) keep open when click on panel fix: tab key behavior blur/show optimization * fix(module:rangepicker): tab key behavior improvements blur/focus optimizations * fix(module:overlay): overlay visible before positioning fix: flickering * fix(module:datepicker): handle escape key * fix(module:datepicker): mark properly current date on panel * fix(module:datepicker): week mode calculates weeks properly

* fix(module: select): enum default value protection (#1368) * fix(module: affix): can't affix while OffsetTop is zero (#1373) * fix(module: affix): can't affix while OffsetTop is zero * use affixed setter for rerendering * limit rerendering * fix(module: input): binding data when the Enter key is pressed (#1375) * fix(module: table): ellipsis can't work (#1376) * feat: add element component (#1378) * refactor: rename `HtmlElement` property case * rename the directory name for overlay * add element component * fix(module: table): Unify FieldName, add DisplayAttribute for DiplayName, fix Filter for DataIndex (#1372) * fix(module: table): Unify FieldName value * fix(module: table): Get column name from DisplayAttribute * fix(module: table): Filter for DataIndex * docs(module: table): Intuitive sorterCompare for Filter demo * fix(module: table): fix header title doesn't display when Sortable is false Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(dialog): add Dispose lifecycle function to Dialog (#1379) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: input): preserve focus and caret position for input password when visibility is toggled (#1377) * set focus when the password button is clicked * add methods for selection * set selectionStart after Focus * fix typescript * set selectionEnd as well * fix a stupid if-condition-bug * remove checks for element * add selectionStart to getDomInfo * get selectionStart from Element * delete unneeded js method Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): can not use DataIndex nullable mode with not nullable property (#1382) * fix(module: table): column header sorter not refresh after ClearSorter is called (#1385) * fix(module:table): column header sorter not refresh after ClearSorter is called * add judgment condition for calling StateHasChanged in IFieldColumn.ClearSorter() * fix(module: form): validation message unique (#1391) * fix(module: tag): closable typo and delete mode (#1393) * fix(module: tag): closable typo and delete mode * return early * test(module: divider): divider tests (#1397) Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: modal): support define modal's style in ModalOptions (#1400) * fix(module: checkbox & switch): Checked parameter binding (#1394) * fix(module:checkbox): allow binding to Checked parameter * fix(module:switch): allow binding to Checked parameter * fix(modules): checkbox & switch get AntInputBoolComponentBase class * test(module:switch): add tests * test(module:checkbox): add tests * test(module:divider): simplify by using id:ignore * docs(module:checkbox): bind example * docs(module:switch): bind example * fix(module:switch): add Control + docs + tests * feat(module:checkboxgroup): add layout and mixed mode * fix: review comments + tests * fix(module:checkboxgroup): parameter name should be MixedMode added more tests * fix demo * fix(module:checkboxgroup): allow toggling between modes Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): OnDataSourceChange called when expected (#1419) * fix(module:select): OnDataSourceChange called when expected * test(module:select): add missing scenario * fix(module: table): DataIndex filter pop up (#1421) * fix(module:overlayTrigger): TrigerRefernece points to OverlayTrigger.Ref. * fix(module:overlay): Show waits for competing code to finish * Update OverlayTrigger.razor.cs * clean code Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat: use ResizeObserver Api instead of window.resize (#1392) * feat: use ResizeObserver Api instead of window.resize * fix(module:select): fall back to window.resize in IE11. * fix(module:domEventService): switch from IsIE11 to IsResizeObserverSupported * fix: Console.WriteLine removed Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): check null in set sorter method (#1423) * fix(module: datepicker): validate manually entered date against format (#1389) * fix(module:datepicker): validate manually entered date against format * fix(module:datepicker): keep frozen the panel until valid date entered * fix(module:datepicker): switch to current culture format * fix(module:datepicker): build fix * fix(module:datepicker): use InvariantCulture when calling ToString on date * fix(module:datepicker): FormatAnalyzer handles also year, week, month & quarter picker * fix(module:datepicker): FormatAnalyzer broken tests * fix: FormatAnalyzer handles prefixes in format. Suffix is handled for picker type = "year" Tests include validation of not changing state * fix: all modes go through format analyzing (inluding week&quarter) * fix(module:datepickerbase): InternalFormat initalized properly for all modes * fix(module:rangepicker): reset opposing date when in conflict with current * fix(module:rangePicker): handle null in second part of range * fix(module:datepicker): switch from BindConverter to partials * tests(module:datepicker): FormatAnalyzer new tests to cover switch from BindConverter * tests(module:datepicker): missed change in tests * fix: focus, key events, reset value to original if not confirmed * fix: bug fix on range & clean-up * Update DatePicker.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): issues in boundaryAdjustMode (#1420) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): incorrect size (#1432) * fix(module: cascader): incorrect size * add test for cascader size * fix(module: table): fix wrong spell for TableFilterCompareOperator.EndsWith (#1434) * fix(module: table): remove an redundant whitespace * fix(module: table): fix wrong spell * fix(module: table): fix wrong spell Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): add SelectedNodesChanged and invoke it after clear selected (#1437) * fix(module: table): fix spell mistake for TableFilterType.FieldType (#1442) * style(module:table): fix spell mistake for TableFilterType.FieldType * style(module:table): fix spell mistake for TableFilterType.FieldType * fix(module: select): fix error for nullable TItem (#1451) * fix(module: checkbox): remove Value initialization blocking (#1459) * fix(module:checkbox): remove Value initialization blocking * Update CheckboxTests.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): support IEnumerable in form (#1460) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): fix dropdown width for IE (#1469) * fix(module:select): fix dropdown width for IE * fix(module:select): add a comment to explain the change * revert 'merge local branch' * revert 'merge local branch' * revert 'merge local branch' Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: dialog): modify delay time to DOM_ MIN_ TIMEOUT_ VALUE (#1445) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: datepicker): Date picker panel click closing + some issues from #1431 (#1452) * fix(module:datetime) keep open when click on panel fix: tab key behavior blur/show optimization * fix(module:rangepicker): tab key behavior improvements blur/focus optimizations * fix(module:overlay): overlay visible before positioning fix: flickering * fix(module:datepicker): handle escape key * fix(module:datepicker): mark properly current date on panel * fix(module:datepicker): week mode calculates weeks properly * fix(module: table): exception is thrown when the DataIndex ends with the get_Item method. (#1485) * fix(module: table): set DisplayName to null if MemberExpression is not found in the DataIndex expression tree (#1488) * feat(module: cascader): support showSearch (#1484) * feat(module: cascader): support showSearch * add empty dropdown * fix clear icon * fix(module: InputNumber): input number self changing (#1490) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: inputNumber): allow culture info to format input (#1480) * fix(module:inputnumber): allow culture info to format input * docs(module:inputnumber): demo & docs * fix translation Co-authored-by: ElderJames <shunjiey@hotmail.com> * docs: update docs for modal dragging (#1497) * fix(module: table): fix built-in filter select option width (#1500) * fix(module: datepicker): fix multiple CultureInfo properties (#1492) * fix(module:datepicker): fix multiple CultureInfo properties * fix(module:datepicker): fix multiple CultureInfo properties * fix(module: input): fix Input component for Guid type (#1510) * fix(module:input): fix Input component for Guid type * docs(module:input): add Guid generic sample code * fix(module:input): add a comment to explain the change * fix(module: input): guid optimization (#1515) * fix:(module: overlay): positioning should take scroll into account (#1511) Co-authored-by: Ocoka <somewhere@network> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: js function getDom return null bug (#1417) * fix: js function getDom return null bug (#1374) * fix: add IF precompiled instruction for observer attribute Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: missing using is causing build failure (#1518) * change log 0.8.1 (#1522) * change log 0.8.1 * fix order Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: Zonciu Liang <zonciu@zonciu.com> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: MihailsKuzmins <47413092+MihailsKuzmins@users.noreply.github.com> Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: 笨木头 <musicvs@163.com> Co-authored-by: Maksim <maksalmak@gmail.com> Co-authored-by: Ivan Ocoka <ocokanet@gmail.com> Co-authored-by: Ocoka <somewhere@network>

…s from #1431 (#1452) * fix(module:datetime) keep open when click on panel fix: tab key behavior blur/show optimization * fix(module:rangepicker): tab key behavior improvements blur/focus optimizations * fix(module:overlay): overlay visible before positioning fix: flickering * fix(module:datepicker): handle escape key * fix(module:datepicker): mark properly current date on panel * fix(module:datepicker): week mode calculates weeks properly

* fix(module: select): enum default value protection (#1368) * fix(module: affix): can't affix while OffsetTop is zero (#1373) * fix(module: affix): can't affix while OffsetTop is zero * use affixed setter for rerendering * limit rerendering * fix(module: input): binding data when the Enter key is pressed (#1375) * fix(module: table): ellipsis can't work (#1376) * feat: add element component (#1378) * refactor: rename `HtmlElement` property case * rename the directory name for overlay * add element component * fix(module: table): Unify FieldName, add DisplayAttribute for DiplayName, fix Filter for DataIndex (#1372) * fix(module: table): Unify FieldName value * fix(module: table): Get column name from DisplayAttribute * fix(module: table): Filter for DataIndex * docs(module: table): Intuitive sorterCompare for Filter demo * fix(module: table): fix header title doesn't display when Sortable is false Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(dialog): add Dispose lifecycle function to Dialog (#1379) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: input): preserve focus and caret position for input password when visibility is toggled (#1377) * set focus when the password button is clicked * add methods for selection * set selectionStart after Focus * fix typescript * set selectionEnd as well * fix a stupid if-condition-bug * remove checks for element * add selectionStart to getDomInfo * get selectionStart from Element * delete unneeded js method Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): can not use DataIndex nullable mode with not nullable property (#1382) * fix(module: table): column header sorter not refresh after ClearSorter is called (#1385) * fix(module:table): column header sorter not refresh after ClearSorter is called * add judgment condition for calling StateHasChanged in IFieldColumn.ClearSorter() * fix(module: form): validation message unique (#1391) * fix(module: tag): closable typo and delete mode (#1393) * fix(module: tag): closable typo and delete mode * return early * test(module: divider): divider tests (#1397) Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: modal): support define modal's style in ModalOptions (#1400) * fix(module: checkbox & switch): Checked parameter binding (#1394) * fix(module:checkbox): allow binding to Checked parameter * fix(module:switch): allow binding to Checked parameter * fix(modules): checkbox & switch get AntInputBoolComponentBase class * test(module:switch): add tests * test(module:checkbox): add tests * test(module:divider): simplify by using id:ignore * docs(module:checkbox): bind example * docs(module:switch): bind example * fix(module:switch): add Control + docs + tests * feat(module:checkboxgroup): add layout and mixed mode * fix: review comments + tests * fix(module:checkboxgroup): parameter name should be MixedMode added more tests * fix demo * fix(module:checkboxgroup): allow toggling between modes Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): OnDataSourceChange called when expected (#1419) * fix(module:select): OnDataSourceChange called when expected * test(module:select): add missing scenario * fix(module: table): DataIndex filter pop up (#1421) * fix(module:overlayTrigger): TrigerRefernece points to OverlayTrigger.Ref. * fix(module:overlay): Show waits for competing code to finish * Update OverlayTrigger.razor.cs * clean code Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat: use ResizeObserver Api instead of window.resize (#1392) * feat: use ResizeObserver Api instead of window.resize * fix(module:select): fall back to window.resize in IE11. * fix(module:domEventService): switch from IsIE11 to IsResizeObserverSupported * fix: Console.WriteLine removed Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): check null in set sorter method (#1423) * fix(module: datepicker): validate manually entered date against format (#1389) * fix(module:datepicker): validate manually entered date against format * fix(module:datepicker): keep frozen the panel until valid date entered * fix(module:datepicker): switch to current culture format * fix(module:datepicker): build fix * fix(module:datepicker): use InvariantCulture when calling ToString on date * fix(module:datepicker): FormatAnalyzer handles also year, week, month & quarter picker * fix(module:datepicker): FormatAnalyzer broken tests * fix: FormatAnalyzer handles prefixes in format. Suffix is handled for picker type = "year" Tests include validation of not changing state * fix: all modes go through format analyzing (inluding week&quarter) * fix(module:datepickerbase): InternalFormat initalized properly for all modes * fix(module:rangepicker): reset opposing date when in conflict with current * fix(module:rangePicker): handle null in second part of range * fix(module:datepicker): switch from BindConverter to partials * tests(module:datepicker): FormatAnalyzer new tests to cover switch from BindConverter * tests(module:datepicker): missed change in tests * fix: focus, key events, reset value to original if not confirmed * fix: bug fix on range & clean-up * Update DatePicker.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): issues in boundaryAdjustMode (#1420) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): incorrect size (#1432) * fix(module: cascader): incorrect size * add test for cascader size * fix(module: table): fix wrong spell for TableFilterCompareOperator.EndsWith (#1434) * fix(module: table): remove an redundant whitespace * fix(module: table): fix wrong spell * fix(module: table): fix wrong spell Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: cascader): add SelectedNodesChanged and invoke it after clear selected (#1437) * fix(module: table): fix spell mistake for TableFilterType.FieldType (#1442) * style(module:table): fix spell mistake for TableFilterType.FieldType * style(module:table): fix spell mistake for TableFilterType.FieldType * fix(module: select): fix error for nullable TItem (#1451) * fix(module: checkbox): remove Value initialization blocking (#1459) * fix(module:checkbox): remove Value initialization blocking * Update CheckboxTests.razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): support IEnumerable in form (#1460) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): fix dropdown width for IE (#1469) * fix(module:select): fix dropdown width for IE * fix(module:select): add a comment to explain the change * revert 'merge local branch' * revert 'merge local branch' * revert 'merge local branch' Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: dialog): modify delay time to DOM_ MIN_ TIMEOUT_ VALUE (#1445) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: datepicker): Date picker panel click closing + some issues from #1431 (#1452) * fix(module:datetime) keep open when click on panel fix: tab key behavior blur/show optimization * fix(module:rangepicker): tab key behavior improvements blur/focus optimizations * fix(module:overlay): overlay visible before positioning fix: flickering * fix(module:datepicker): handle escape key * fix(module:datepicker): mark properly current date on panel * fix(module:datepicker): week mode calculates weeks properly * fix(module: table): exception is thrown when the DataIndex ends with the get_Item method. (#1485) * fix(module: table): set DisplayName to null if MemberExpression is not found in the DataIndex expression tree (#1488) * feat(module: cascader): support showSearch (#1484) * feat(module: cascader): support showSearch * add empty dropdown * fix clear icon * fix(module: InputNumber): input number self changing (#1490) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: inputNumber): allow culture info to format input (#1480) * fix(module:inputnumber): allow culture info to format input * docs(module:inputnumber): demo & docs * fix translation Co-authored-by: ElderJames <shunjiey@hotmail.com> * docs: update docs for modal dragging (#1497) * fix(module: table): fix built-in filter select option width (#1500) * fix(module: datepicker): fix multiple CultureInfo properties (#1492) * fix(module:datepicker): fix multiple CultureInfo properties * fix(module:datepicker): fix multiple CultureInfo properties * fix(module: input): fix Input component for Guid type (#1510) * fix(module:input): fix Input component for Guid type * docs(module:input): add Guid generic sample code * fix(module:input): add a comment to explain the change * fix(module: input): guid optimization (#1515) * fix:(module: overlay): positioning should take scroll into account (#1511) Co-authored-by: Ocoka <somewhere@network> Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: js function getDom return null bug (#1417) * fix: js function getDom return null bug (#1374) * fix: add IF precompiled instruction for observer attribute Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix: missing using is causing build failure (#1518) * change log 0.8.1 (#1522) * change log 0.8.1 * fix order Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: Zonciu Liang <zonciu@zonciu.com> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: MihailsKuzmins <47413092+MihailsKuzmins@users.noreply.github.com> Co-authored-by: mihails.kuzmins <mihails.kuzmins@daytongroup.lv> Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: 笨木头 <musicvs@163.com> Co-authored-by: Maksim <maksalmak@gmail.com> Co-authored-by: Ivan Ocoka <ocokanet@gmail.com> Co-authored-by: Ocoka <somewhere@network>

anddrzejb added 4 commits May 1, 2021 23:01

fix(module:datetime) keep open when click on panel

75f0f89

fix: tab key behavior blur/show optimization

fix(module:rangepicker): tab key behavior improvements

1d9098c

blur/focus optimizations

fix(module:overlay): overlay visible before positioning

153a3b8

fix: flickering

fix(module:datepicker): handle escape key

a1668d1

pr-triage bot added the PR: unreviewed label May 2, 2021

anddrzejb requested a review from Zonciu May 2, 2021 07:33

anddrzejb changed the title ~~Date picker panel click closing~~ fix(module:datepicker): Date picker panel click closing May 2, 2021

fix(module:datepicker): mark properly current date on panel

934acca

anddrzejb changed the title ~~fix(module:datepicker): Date picker panel click closing~~ fix(module:datepicker): Date picker panel click closing + issues from #1431 May 2, 2021

anddrzejb changed the title ~~fix(module:datepicker): Date picker panel click closing + issues from #1431~~ fix(module:datepicker): Date picker panel click closing + some issues from #1431 May 2, 2021

Zonciu requested review from mutouzdl and removed request for Zonciu May 2, 2021 19:30

fix(module:datepicker): week mode calculates weeks properly

7ad46ed

Merge branch 'master' into datePickerPanelClickClosing

b2b2463

mutouzdl approved these changes May 6, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels May 6, 2021

Merge branch 'master' into datePickerPanelClickClosing

6b63d43

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels May 6, 2021

anddrzejb mentioned this pull request May 6, 2021

DatePicker: week count, date&time picker focus, quarter range & placeholder #1429

Closed

ElderJames approved these changes May 7, 2021

View reviewed changes

pr-triage bot removed the PR: unreviewed label May 7, 2021

pr-triage bot added the PR: reviewed-approved label May 7, 2021

ElderJames merged commit 8430c76 into ant-design-blazor:master May 7, 2021

pr-triage bot added PR: merged and removed PR: reviewed-approved labels May 7, 2021

anddrzejb deleted the datePickerPanelClickClosing branch May 7, 2021 07:34

anddrzejb mentioned this pull request May 11, 2021

fix(module: drawer): OffsetX and offsetY do not work (#1435) #1448

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(module:datepicker): Date picker panel click closing + some issues from #1431 #1452

fix(module:datepicker): Date picker panel click closing + some issues from #1431 #1452

anddrzejb commented May 2, 2021

github-actions bot commented May 2, 2021 •

edited

Loading

codecov-commenter commented May 2, 2021 •

edited

Loading

anddrzejb commented May 2, 2021 •

edited

Loading

Zonciu commented May 2, 2021

anddrzejb commented May 3, 2021

mutouzdl commented May 6, 2021

anddrzejb commented May 6, 2021

fix(module:datepicker): Date picker panel click closing + some issues from #1431 #1452

fix(module:datepicker): Date picker panel click closing + some issues from #1431 #1452

Conversation

anddrzejb commented May 2, 2021

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

☑️ Self Check before Merge

github-actions bot commented May 2, 2021 • edited Loading

codecov-commenter commented May 2, 2021 • edited Loading

Codecov Report

anddrzejb commented May 2, 2021 • edited Loading

Zonciu commented May 2, 2021

anddrzejb commented May 3, 2021

mutouzdl commented May 6, 2021

anddrzejb commented May 6, 2021

github-actions bot commented May 2, 2021 •

edited

Loading

codecov-commenter commented May 2, 2021 •

edited

Loading

anddrzejb commented May 2, 2021 •

edited

Loading