Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up suffix icon show issue #2226

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

KarimFereidooni
Copy link
Contributor

Fix up suffix icon show issue

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix up suffix icon show issue
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Fix up SuffixIcon show issue
@dnfadmin
Copy link

dnfadmin commented Jan 4, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

@ElderJames
Copy link
Member

@KarimFereidooni Thanks for contribute this, please sign the CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #2226 (c397d4c) into master (9cbf595) will increase coverage by 1.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
+ Coverage   27.75%   29.72%   +1.96%     
==========================================
  Files         496      519      +23     
  Lines       33090    25362    -7728     
  Branches        0      247     +247     
==========================================
- Hits         9185     7538    -1647     
+ Misses      23905    17784    -6121     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/date-picker/DatePicker.razor 66.66% <ø> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 43.90% <0.00%> (-2.48%) ⬇️
components/menu/SubMenu.razor 63.93% <0.00%> (-2.30%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd18de...c397d4c. Read the comment docs.

@KarimFereidooni
Copy link
Contributor Author

@KarimFereidooni Thanks for contribute this, please sign the CLA.
Hi @ElderJames I have signed the CLA

@ElderJames ElderJames merged commit da78fba into ant-design-blazor:master Jan 7, 2022
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants