Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: datepicker): an exception is caused when passes the value as null #2688

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #2676

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #2688 (a78035e) into master (9805945) will increase coverage by 1.23%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
+ Coverage   38.83%   40.07%   +1.23%     
==========================================
  Files         505      543      +38     
  Lines       33591    25670    -7921     
  Branches        0      260     +260     
==========================================
- Hits        13046    10287    -2759     
+ Misses      20545    15343    -5202     
- Partials        0       40      +40     
Impacted Files Coverage Δ
components/date-picker/RangePicker.razor.cs 54.06% <40.00%> (+3.61%) ⬆️
components/breadcrumb/Breadcrumb.razor.cs 90.00% <0.00%> (-10.00%) ⬇️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/avatar/AvatarGroup.razor 75.00% <0.00%> (-8.34%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/core/Helpers/DateHelper.cs 85.33% <0.00%> (-4.90%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...onents/date-picker/internal/DatePickerHeader.razor 41.86% <0.00%> (-3.21%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
... and 443 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames merged commit 093e606 into master Sep 8, 2022
@ElderJames ElderJames deleted the fix/rangepicker-value-null branch September 8, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception is caused when Rangepicker passes the @bind-value as null
1 participant