Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload-time => history #53

Merged
merged 7 commits into from
May 7, 2019
Merged

reload-time => history #53

merged 7 commits into from
May 7, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 4, 2019

@afc163 afc163 requested a review from zombieJ April 4, 2019 10:07
@zombieJ
Copy link
Member

zombieJ commented Apr 5, 2019

@wendzhue , I see you add Beak Change label. Is that safe to merge this?

@afc163
Copy link
Member Author

afc163 commented Apr 5, 2019

I don't see https://ng.ant.design/components/icon/zh using reload-time and mr icons.

@wzhudev
Copy link
Collaborator

wzhudev commented Apr 5, 2019

@zombieJ I am afraid merging this PR would introduce a breaking change if we don't get down to some adapting works - which is quite muddy.

@zombieJ
Copy link
Member

zombieJ commented Apr 5, 2019

Agree. Maybe we can support alias?

ref: #32

@afc163
Copy link
Member Author

afc163 commented Apr 11, 2019

发一个 2.0.0 好了,上层框架去抹平 breaks

@wzhudev
Copy link
Collaborator

wzhudev commented Apr 11, 2019

有一个 map 吗?

@afc163
Copy link
Member Author

afc163 commented Apr 11, 2019

@zombieJ zombieJ merged commit 04025a1 into master May 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the rename-history-icon branch May 7, 2019 13:42
@rsmolkin
Copy link

rsmolkin commented May 7, 2019

Should these new icons be shown here: https://ant.design/components/icon/

@zombieJ
Copy link
Member

zombieJ commented May 8, 2019

Should these new icons be shown here: https://ant.design/components/icon/

We released 2.0 which will update in next minor version of antd: ant-design/ant-design#15874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History icon
4 participants