fix(icons-react): use HTMLAttributes instead of HTMLProps #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jia-nan
approved these changes
Mar 15, 2024
|
Will there be an update to version 4.x? Because @types/react also relased version 17.0.78, @ant-desgin/icon@4.x will also report this error. |
vagusX
added a commit
that referenced
this pull request
Mar 15, 2024
MadCcc
pushed a commit
that referenced
this pull request
Mar 15, 2024
…)" This reverts commit 0887dca.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
@types/reactant-design#47886Reference from gpt-4
React-specific attributes that are included in React.HTMLProps but not in React.HTMLAttributes include:
ref: This is a special attribute that can be used to get a reference to the underlying DOM element or the instance of a class component. It's useful for direct manipulation of DOM elements.
key: This is a special attribute that helps React identify which items have changed, are added, or are removed in lists. It's important for efficient re-rendering of lists.