Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make InputItem clear icon behave properly in Android. #251

Merged
merged 2 commits into from
Jan 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 57 additions & 14 deletions components/input-item/__tests__/__snapshots__/demo.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
<RCTScrollView
automaticallyAdjustContentInsets={false}
keyboardShouldPersistTaps="handled"
showsHorizontalScrollIndicator={false}
showsVerticalScrollIndicator={false}
style={
Expand Down Expand Up @@ -89,17 +90,20 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
Object {
"color": "#f50",
},
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -221,15 +225,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -301,18 +308,21 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {
"backgroundColor": "#dddddd",
"color": "#bbbbbb",
},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -367,15 +377,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -436,15 +449,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -502,15 +518,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -727,15 +746,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -794,15 +816,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -861,15 +886,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -972,17 +1000,20 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
Object {
"color": "#f50",
},
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -1078,15 +1109,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -1145,15 +1179,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -1212,15 +1249,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={true}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down Expand Up @@ -1279,15 +1319,18 @@ exports[`renders ./components/input-item/demo/basic.tsx correctly 1`] = `
secureTextEntry={false}
style={
Array [
Object {
"height": 35,
},
Object {
"backgroundColor": "transparent",
"color": "#000000",
"flex": 1,
"fontSize": 17,
"height": 35,
},
null,
Object {},
undefined,
]
}
textAlign="left"
Expand Down
1 change: 1 addition & 0 deletions components/input-item/demo/basic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export default class BasicInputItemExample extends React.Component<any, any> {
automaticallyAdjustContentInsets={false}
showsHorizontalScrollIndicator={false}
showsVerticalScrollIndicator={false}
keyboardShouldPersistTaps={'handled'}
>
<List renderHeader={'基本'}>
<InputItem
Expand Down
Loading