Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: hard to focus ref#2177 #2560

Merged
merged 1 commit into from
May 22, 2018
Merged

hotfix: hard to focus ref#2177 #2560

merged 1 commit into from
May 22, 2018

Conversation

quentinyang
Copy link
Contributor

@quentinyang quentinyang commented May 22, 2018

Issues: Hard to focus. #2177 #2285
Solution: Auto focus when clicking input.

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

Auto focus when clicking input.
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #2560 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   58.39%   58.34%   -0.06%     
==========================================
  Files         258      258              
  Lines        4579     4583       +4     
  Branches     1294     1296       +2     
==========================================
  Hits         2674     2674              
- Misses       1900     1904       +4     
  Partials        5        5
Flag Coverage Δ
#rn 60.21% <ø> (ø) ⬆️
#web 56.72% <0%> (-0.1%) ⬇️
Impacted Files Coverage Δ
components/modal/prompt.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756a9e2...c723d60. Read the comment docs.

@warmhug warmhug merged commit c17c5ff into ant-design:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants