feat: add tabBarPosition on TabBar #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
doxiaodong
force-pushed
the
feat-tabbar-position
branch
from
b2eceeb to
b1a088d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2564 +/- ##
=======================================
Coverage 59.24% 59.24%
=======================================
Files 92 92
Lines 2201 2201
Branches 626 626
=======================================
Hits 1304 1304
Misses 891 891
Partials 6 6
Continue to review full report at Codecov.
|
doxiaodong
force-pushed
the
feat-tabbar-position
branch
from
b1a088d to
76bc6f5
Compare
|
RN 代码已经拆分出去，更新到了 master 方便开发，需要解决此处冲突。 |
doxiaodong
force-pushed
the
feat-tabbar-position
branch
from
76bc6f5 to
757aa2c
Compare
zhang740
reviewed
Jun 7, 2018
components/tab-bar/index.tsx
Outdated
| @@ -99,7 +100,11 @@ class AntTabBar extends React.Component<AntTabbarProps, any> { | |||
| animated, | |||
| swipeable, | |||
| noRenderContent, | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
尴尬，我的错。 不过这样看来我们把 check 放到 prepush 比 precommit 更合理啊
doxiaodong
force-pushed
the
feat-tabbar-position
branch
from
757aa2c to
e8179f4
Compare
|
之前试过功能应该没问题，我觉得再测一下 Android iOS 多个机型 展示上的兼容性，OK了就合了吧。 |
|
像这种改动增加一下测试用例吧 @doxiaodong |
Add new props tabBarPosition: 'top' | 'bottom'
doxiaodong
force-pushed
the
feat-tabbar-position
branch
from
e8179f4 to
393a70f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2526
This change is