-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:(imagePicker) add config disableDelete #3185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
=========================================
Coverage ? 60.07%
=========================================
Files ? 92
Lines ? 2279
Branches ? 655
=========================================
Hits ? 1369
Misses ? 901
Partials ? 9
Continue to review full report at Codecov.
|
@@ -12,4 +12,5 @@ export interface ImagePickerPropTypes { | |||
accept?: string; | |||
length?: number | string; | |||
capture?: any; // 本应该是boolean | string; 但是因为@types/react中interface InputHTMLAttributes<T>定义问题,写成any跳过ts检查 | |||
disableDelete?: boolean, // 是否显示删除按钮,默认false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个注释为是否隐藏删除按钮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
新特性要发到 minor 版本上。 |
close #2150
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is