Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(imagePicker) add config disableDelete #3185

Merged
merged 4 commits into from
Apr 28, 2019
Merged

feat:(imagePicker) add config disableDelete #3185

merged 4 commits into from
Apr 28, 2019

Conversation

likezero
Copy link
Contributor

@likezero likezero commented Apr 22, 2019

close #2150

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned likezero Apr 22, 2019
@ghost ghost added the In Progress label Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3b4fd9e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3185   +/-   ##
=========================================
  Coverage          ?   60.07%           
=========================================
  Files             ?       92           
  Lines             ?     2279           
  Branches          ?      655           
=========================================
  Hits              ?     1369           
  Misses            ?      901           
  Partials          ?        9
Flag Coverage Δ
#web 60.07% <100%> (?)
Impacted Files Coverage Δ
components/image-picker/index.tsx 33.06% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4fd9e...9c409f6. Read the comment docs.

@@ -12,4 +12,5 @@ export interface ImagePickerPropTypes {
accept?: string;
length?: number | string;
capture?: any; // 本应该是boolean | string; 但是因为@types/react中interface InputHTMLAttributes<T>定义问题,写成any跳过ts检查
disableDelete?: boolean, // 是否显示删除按钮,默认false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释为是否隐藏删除按钮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@doxiaodong doxiaodong merged commit 20d3c88 into master Apr 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-delete branch April 28, 2019 02:17
@afc163
Copy link
Member

afc163 commented May 9, 2019

新特性要发到 minor 版本上。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImagePicker 隐藏删除图标属性
3 participants