fix: (ImageUploader) change the deleted logic to delete images by index #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awmleer
requested changes
Dec 2, 2021
| @@ -180,7 +180,7 @@ export const ImageUploader: FC<ImageUploaderProps> = p => { | |||
| onDelete={async () => { | |||
| const canDelete = await props.onDelete?.(fileItem) | |||
| if (canDelete === false) return | |||
| setValue(value.filter(x => x.url !== fileItem.url)) | |||
| setValue(value.filter((x, i) => i !== index)) | |||
There was a problem hiding this comment.
不如直接用 splice？
Suggested change
| setValue(value.filter((x, i) => i !== index)) | |
| setValue([...value].splice(i, 1)) |
There was a problem hiding this comment.
也可以，但是那样得写3行代码，splice的返回值是移除项组成的数组。
awmleer
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4328
我发现删除图片是通过url，相同url图片就会出现BUG。
现在通过index删除。