Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove menu authorized #2911

Merged
merged 5 commits into from
Nov 23, 2018
Merged

remove menu authorized #2911

merged 5 commits into from
Nov 23, 2018

Conversation

xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Nov 19, 2018 •
edited
Loading

Close: #2910
在最外层对数据做一个过滤，这样menu里面就直接展示数据就好了，不需要其他多余的逻辑？
如果觉得这样可以的话，我再删掉menu里面的多余逻辑

@xiaohuoni xiaohuoni changed the title try https://github.com/ant-design/ant-design-pro/issues/2910 try #2910 Nov 19, 2018
@netlify
Copy link

netlify bot commented Nov 19, 2018 •
edited
Loading

Deploy preview for ant-design-pro ready!

Built with commit 75c7e90

https://deploy-preview-2911--ant-design-pro.netlify.com

@chenshuai2144
Copy link
Collaborator

BasicLayout.js 已经太长 太可怕了。放到别的地方去了吧，modal 也许是个好办法。

@afc163
Copy link
Member

afc163 commented Nov 20, 2018

题外话，@xiaohuoni 有没有兴趣加入我们。

@chenshuai2144
Copy link
Collaborator

@xiaohuoni 楼上是我们老板

@xiaohuoni
Copy link
Member Author

@chenshuai2144 按这种思路可以吗？

@xiaohuoni
Copy link
Member Author

@afc163 感谢，我暂时离不开福州😁

@chenshuai2144
Copy link
Collaborator

可以的，把权限做为了filter的一个参数，现在就是这么做的，只是埋的比较深

@xiaohuoni
Copy link
Member Author

@chenshuai2144 帅帅，看下，要怎么修改

@chenshuai2144
Copy link
Collaborator

新建一个菜单的modal。menudata 处理全部放进去

@xiaohuoni
Copy link
Member Author

考虑过，但是感觉这么做实际意义不大，真正用到项目开发中，页面都有自己的model，而且这个menudata可能也是从服务端获取的，又要删掉他的model

@chenshuai2144
Copy link
Collaborator

menudata 从服务端获取的话只要
改modal就好了，现在放在了组建内部，感觉很怪。

@xiaohuoni
Copy link
Member Author

那我改一下，是有点奇怪。

@xiaohuoni
Copy link
Member Author

感觉放到工具类里面更合适

@xiaohuoni xiaohuoni changed the title try #2910 remove menu authorized Nov 20, 2018
@chenshuai2144
Copy link
Collaborator

modal 吧， modal 本来就是为了管理各种副作用的

@xiaohuoni
Copy link
Member Author

@chenshuai2144 好了

@xiaohuoni xiaohuoni mentioned this pull request Nov 20, 2018
Closed
4 tasks
@qteamcheng
Copy link

把menuData 做成mock呗，我们现在的项目这块改成了从服务端获取，其实大部分项目菜单也是从服务端获取的，菜单权限控制一般在服务端做。拜托，要不每次开项目使用最新版本都要改一次。

@xiaohuoni
Copy link
Member Author

@qteamcheng 理解，预计和物料方案一起处理这些问题。

@xiaohuoni
Merge branch 'master' of https://github.com/ant-design/ant-design-pro …
75c7e90 
…into remove-menu-authorized

# Conflicts:
#	src/layouts/BasicLayout.js
@xiaohuoni xiaohuoni merged commit 91be534 into master Nov 23, 2018
@alexinfurs alexinfurs mentioned this pull request Nov 25, 2018
Closed
@qteamcheng
Copy link

@xiaohuoni @chenshuai2144 , 现在菜单数据放到modal 中好多了。感谢。
但是‘’用户权限‘’和‘’路由配置‘’耦合性还是比较大啊，现在角色权限放在router.config.js 中，实际项目角色及权限都是在服务端可配置的。 能否考虑剥离一下啊，现在的权限判断应该是 登录用户 和 路由权限 的比对，能否先改成判断 当前path是否在menuData 中，如过不在，就403。并把这些代码全部放到modal中，以后再改就好整了。

不知道说清楚了没。：）

@afc163 afc163 deleted the remove-menu-authorized branch December 10, 2018 08:08
@xiaohuoni
Copy link
Member Author

@qteamcheng #3103 这里跟进

@Anonymity94 Anonymity94 mentioned this pull request Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaohuoni @chenshuai2144 @afc163 @qteamcheng