Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stylelint rules, fix propTypes error of TagSelect #3518

Merged
merged 11 commits into from
Feb 12, 2019
Merged

Enhance stylelint rules, fix propTypes error of TagSelect #3518

merged 11 commits into from
Feb 12, 2019

Conversation

laozhu
Copy link
Contributor

@laozhu laozhu commented Feb 11, 2019

Commits in this PR:

Using vscode

If you are using vscode with vscode-stylelint extension, this is my vscode config for stylelint (with vscode-prettier extension installed).

{
  "editor.formatOnSave": true,

  // Stylelint
  // https://github.com/shinnn/vscode-stylelint#optional-but-recommended-setup
  "css.validate": false,
  "less.validate": false,
  "scss.validate": false,

  // Prettier
  "prettier.stylelintIntegration": true,
}

With these configs, when you save your CSS, SCSS or LESS files, vscode will automatically sort your CSS properties and fix some fixable stylelint rules.

Using others

If you are using other IDEs or editors, the config should be different from vscode, but you can fix all files just run script below in your terminal:

# using npm
$ npm run lint:fix

# using yarn
$ yarn lint:fix

@netlify
Copy link

netlify bot commented Feb 11, 2019

Deploy preview for ant-design-pro ready!

Built with commit a5570f6

https://deploy-preview-3518--ant-design-pro.netlify.com

@laozhu laozhu changed the title enhance Stylelint rules Enhance stylelint rules, fix propTypes error of TagSelect Feb 11, 2019
@chenshuai2144
Copy link
Collaborator

Great, but css sorting makes me feel bad.

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 Maybe too strict for writing CSS? I use this with vscode and vscode-stylelint extension, set editor.formatOnSave to true, It will be automatically sorted while I’m saving file.

If you don’t like css sorting, I will revert the commits of css sorting today.

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 I have removed CSS sorting from this PR.

@chenshuai2144
Copy link
Collaborator

If it can be sorted automatically, I think it is good, no need to delete

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 I have got CSS sorting feature back 😄

@chenshuai2144
Copy link
Collaborator

ok,This will be a great job

@chenshuai2144
Copy link
Collaborator

why?

  "css.validate": false,
  "less.validate": false,
  "scss.validate": false,

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 vscode will make another duplicate lint info, see below link:

https://github.com/shinnn/vscode-stylelint#optional-but-recommended-setup

@chenshuai2144
Copy link
Collaborator

Can add a document for use in each ide

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 I am not familiar with other IDEs or editors, but I think npm run lint:fix is what they want 😄. I am very happy to contribute document about stylelint and others, but where should I commit to?

@chenshuai2144
Copy link
Collaborator

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 Can I add a code style section of ant-design-pro there? I will write sth about prettier, eslint, tslint and stylelint in this section.

@chenshuai2144 chenshuai2144 merged commit ac37440 into ant-design:master Feb 12, 2019
@chenshuai2144
Copy link
Collaborator

@laozhu 有兴趣帮 antd 也搞一下吗?

@chenshuai2144
Copy link
Collaborator

chenshuai2144 commented Feb 12, 2019

  • Write document for code style and IDEs integrated

Create a new issue in the site

@laozhu
Copy link
Contributor Author

laozhu commented Feb 12, 2019

@chenshuai2144 没问题的,晚上搞起来。

chenshuai2144 pushed a commit that referenced this pull request Mar 5, 2019
* fix: error-processing-request (#3402)

* Close: #3398

* error authority is undefined

* feat: add new config "menu.enableLocale" (#3310)

* feat: add new config "layoutLocal"

* Use enableLayoutLocale instead of layoutLocale

* Use enableMenuLocale instead of enableMenuLocale

* use menu.disableLocal

* Fix an issue in list item Add (#3423)

* try fix test error (#3424)

* try fix test error

* try fix ci error in windows

* feat: Routing is in the root directory can also matchs. (#3364)

* fix viewport content

Error parsing a meta element's content: ';' is not a valid key-value pair separator. Please use ',' instead.

* Set up CI with Azure Pipelines (#3268)

* Set up CI with Azure Pipelines

* change some js filemod to 644 (#3447)

* fix #2851 (#3440)

* add responsive-table (#3472)

* remove PureComponent (#3470)

* remove PureComponent

* fix typo

* chore: upgrade jest-puppeteer and remove some puppeteer config

* html prettier (#3473)

* prettier html

* update dependencies

* centering icon

* set icon size

* edit text

* Removed redundant colon - zh-CN (#3480)

* Removed redundant colon - zh-CN

* Removed redundant colon - zh-TW

* Removed redundant colon - en-US

* fix: horizontal scroll bar appears on SiderMenu with light navTheme (#3381)

* fix: horizontal scroll bar appears on SiderMenu with light navTheme

* a better solution

* fix Badge error (#3488)

* fix tag error

* Move flags to badges in README

* Make "home" optional in breadcrumb (#3416)

* fixed submenu collapsed when refresh page (#3494)

* perf: add checkout config in azure (#3498)

* 🆙 upgrade deps (#3503)

* fix: unresponsive collapse btn on mobile (#3504)

* style: prettier SiderMenu.js (#3501)

* style: prettier SiderMenu.js

* new config file

* fix ci error

* feat: support pwa config (#3508)

* feat: support pwa config

* style: change code style

* reset ci (#3507)

* add actionsText prop to TagSelect, add locales to List page #3367 (#3442)

* add actionsText prop to TagSelect, add locales to List page

* add actionsText prop to TagSelect, add locales to List page

* 修正繁体中文文案 (#3511)

* Route authority attribute behavior (#3514)

* fix customize menu icon bug (#3509)

* fix customize menu icon bug

当采用自定义菜单图标(即通过url引用方式)且菜单折叠时,文字不隐藏

* fix customize menu icon bug

修改样式

* feat: add a demo that jump to details (#3502)

* feat: add a demo that jump to details

* feat: hide progress in coi

* remove trigger config

* remove fetchDepth: 1

* refactor: userinfo and application  from api

* style: fix code style

* Enhance stylelint rules, fix propTypes error of TagSelect (#3518)

* add stylelint shareable config for css modules

* fix CSS pseudo element with double colon

* support stylelint declaration-block-no-ignored-properties rule

* support sorted CSS properties order for readability and consistency

* autofix order of all styles by lint:fix script

* fix propTypes error of TagSelect component

* Revert "autofix order of all styles by lint:fix script"

This reverts commit 51cb9d0.

* Revert "support sorted CSS properties order for readability and consistency"

This reverts commit ff6c24d.

* make lint:fix work for stylelint

* Revert "Revert "autofix order of all styles by lint:fix script""

This reverts commit 946ed0a.

* Revert "Revert "support sorted CSS properties order for readability and consistency""

This reverts commit 31b557e.

* Update README.zh-CN.md

* doc: add umi-badge (#3538)

* doc: add umi-badge

* Update README.ru-RU.md (#3539)

add umi badge

* feat: Officially traded will use cdn to optimize bizchart (#3535)

* route authority attribute behavior no use while (#3522)

* route authority attribute behavior no use while

* i18n pt-BR: analysis & component (#3540)

* Translation of form and monitor (pt-BR)

* Change flag of Portugal (pt-PT) to Brazil (pt-BR)

* i18n pt-BR: analysis & component

* Fix missing export default  (#3525)

* fix types missing export default

* Update package.json

* Update index.d.ts

* Update index.d.ts

* Update index.d.ts

* 增加IconFont组件、菜单图标可以使用自己的IconFont项目图标 (#3517)

* feature:
1.add iconfont component;
2.menu can add iconfont icon.

* fix: 调整菜单引入iconfont的方式为String.
1. 新增IconFont组件,需在组件内配置自己的IconFont图标项目地址;
2. 然后,菜单图标可以引入自己的IconFont图标,图标字符串以icon-开头.

* ajust: put the IconFont Script Url into defaultSetting.js

* 调整iconfontUrl名称

* fix:注释更新

* 留空iconfontUrl

* Site title use defaultSettings (#3546)

* Site title od top use defaultSettings (#3551)

* pref: optimize performance (#3542)

* pref: optimize performance

* pref: use less img

* pref: use less img

* fix: Eslint warning of Mock dependence (#3554)

* perf: use requestAnimationFrame

* Fix: onPressEnter trigger twice login request in IE11

* Fix: onPressEnter trigger twice login request in IE11

* Login title (#3564)

* Added document title to UserLayout by identifying the current route object and using its name kaey to set the title

* Adjusment to document title

* feat: use same getPageTile function

* when select 3 item ,text branch

* style: use standard frontmatter

* doc: remove subtitle in en-Us

* better demo md

* fix PageHeader no title bug (#3583)

* fix PageHeader no title bug

* default value

* fix: React does not recognize the `staticContext` prop on a DOM element. (#3582)

* doc: better demo

* remove drawer onHandleClick, ant-design/ant-design#15051 (#3602)

* Use Umi Permission Routing (#3587)

Use Umi Permission Routing

* fix the problem that breadcrumbNameMap does not contain hidden menus. (#3606)

* Update enzyme to version 3.9.0

* Update package.json

* Update jest-puppeteer to version 4.0.0

* Update prettier to version 1.16.4

* Update package.json

* 🐛 fix TagCloud style override bug (#3632)

* Update stylelint-config-prettier to version 5.0.0

* Update index.md (#3644)

* dead code (#3639)

* dead code
Close: #3637

* delete dead props

* [NoticeIcon] Replace `LoadMore` with `ViewMore` button (#3439)

* enhance LoadMore: Debounce

* enhance LoadMore: debounce

* use Tag instead of div

* rewrite margin-right of Tag

* hide LoadMore in NoticeList without onLoadMore

* another style

* fix a mistake

* remove local config

* fix a bug

* user-select: none

* remover local config

* replace global/fetchMoreNotices with global/fetchNotices

* replace LoadMore with ViewMore

* remove prop `name` in NoticeIcon

* fix: tab title does not show correct text

* Fix margin top style error of Description List following Description List (#3653)

* fix login model statu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants