Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] fix e2e test #3915

Merged
merged 14 commits into from
May 7, 2019
Merged

[v4] fix e2e test #3915

merged 14 commits into from
May 7, 2019

Conversation

imhele
Copy link
Contributor

@imhele imhele commented Apr 4, 2019

No description provided.

@netlify
Copy link

netlify bot commented Apr 4, 2019

Deploy preview for ant-design-pro ready!

Built with commit 37104d4

https://deploy-preview-3915--ant-design-pro.netlify.com

@imhele imhele marked this pull request as ready for review April 4, 2019 02:32
@imhele
Copy link
Contributor Author

imhele commented Apr 4, 2019

@chenshuai2144 本地 win 没问题,这是啥原因?azure link

FAIL src/e2e/baseLayout.e2e.js (5.518s)
  ● Homepage › test pages /

    TimeoutError: waiting for selector "footer" failed: timeout 3000ms exceeded

      21 |   const testPage = path => async () => {
      22 |     await page.goto(`${BASE_URL}${path}`);
    > 23 |     await page.waitForSelector('footer', {
         |                ^
      24 |       timeout: 3000,
      25 |     });
      26 |     const haveFooter = await page.evaluate(

      at new WaitTask (node_modules/puppeteer/lib/DOMWorld.js:554:28)
      at DOMWorld._waitForSelectorOrXPath (node_modules/puppeteer/lib/DOMWorld.js:483:22)
      at DOMWorld.waitForSelector (node_modules/puppeteer/lib/DOMWorld.js:437:17)
      at Frame.waitForSelector (node_modules/puppeteer/lib/FrameManager.js:608:47)
      at Frame.<anonymous> (node_modules/puppeteer/lib/helper.js:111:23)
      at Page.waitForSelector (node_modules/puppeteer/lib/Page.js:1073:29)
      at waitForSelector (src/e2e/baseLayout.e2e.js:23:16)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (src/e2e/baseLayout.e2e.js:5:103)
      at _next (src/e2e/baseLayout.e2e.js:7:194)

image

@chenshuai2144
Copy link
Collaborator

merge 一下 master

@chenshuai2144
Copy link
Collaborator

merge 一下 v4

@imhele imhele changed the title [v4] Merge master and fix types definition [v4] Remove useless patches of types definition and fix e2e test Apr 11, 2019
package.json Outdated Show resolved Hide resolved
@imhele imhele changed the title [v4] Remove useless patches of types definition and fix e2e test [v4] fix e2e test May 7, 2019
@imhele imhele mentioned this pull request May 7, 2019
@chenshuai2144
Copy link
Collaborator

有好多无关提交。清理一下

@imhele
Copy link
Contributor Author

imhele commented May 7, 2019

ok

@chenshuai2144 chenshuai2144 merged commit 0858fb9 into ant-design:v4 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants