-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): solve WalletConnect showQrModal true will show two modals #988
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
看 wallet 里面的逻辑,直接判定 getQrCode 是否存在就能判定 useWalletConnectOfficialModal 为 true or false 了 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 720 720
Lines 22210 22220 +10
Branches 1287 1289 +2
===========================================
+ Hits 22210 22217 +7
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
d99992b
to
31a3d27
Compare
// for special wallet, such as WalletConnect, useWalletConnectOfficialModal is true, use official modal | ||
if ( | ||
wallet && | ||
wallet?.name === 'WalletConnect' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix in #1151 |
[中文版模板 / Chinese template]
💡 Background and solution
links: #982
[Bug] WalletConnect showQrModal 为 true 时,出现两个弹窗 #982
🔗 Related issue link