Added "middle" and "small" classes for the Card component (like Table) #13180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbroadbent
force-pushed
the
card-small-middle
branch
from
7c9f9e5 to
2ca75af
Compare
1 task
ndbroadbent
force-pushed
the
card-small-middle
branch
2 times, most recently
from
aed55a0 to
1f5c60c
Compare
Codecov Report
@@ Coverage Diff @@
## feature #13180 +/- ##
===========================================
- Coverage 93.26% 93.25% -0.02%
===========================================
Files 222 222
Lines 6195 6196 +1
Branches 1720 1721 +1
===========================================
Hits 5778 5778
- Misses 409 410 +1
Partials 8 8
Continue to review full report at Codecov.
|
|
Deploy preview for ant-design ready! Built with commit 7c9f9e566b8b38be43d90be0c35631570c59fe57 |
|
Deploy preview for ant-design ready! Built with commit 77c7287 |
ndbroadbent
force-pushed
the
card-small-middle
branch
3 times, most recently
from
22f6b8d to
7f11611
Compare
ilanus
reviewed
Nov 17, 2018
ilanus
reviewed
Nov 17, 2018
ilanus
reviewed
Nov 17, 2018
ndbroadbent
force-pushed
the
card-small-middle
branch
from
7f11611 to
aa403d0
Compare
|
Thanks for your feedback @ilanus, I have updated the PR |
ndbroadbent
force-pushed
the
card-small-middle
branch
from
aa403d0 to
b6fdc0a
Compare
ilanus
reviewed
Nov 18, 2018
ilanus
reviewed
Nov 18, 2018
ndbroadbent
force-pushed
the
card-small-middle
branch
2 times, most recently
from
7a39ad9 to
0b3ee13
Compare
afc163
reviewed
Dec 11, 2018
afc163
reviewed
Dec 11, 2018
afc163
reviewed
Dec 11, 2018
afc163
reviewed
Dec 11, 2018
ndbroadbent
force-pushed
the
card-small-middle
branch
2 times, most recently
from
58da314 to
464632c
Compare
ndbroadbent
force-pushed
the
card-small-middle
branch
from
464632c to
77c7287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master, feature for branchfeature.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
Fixes #13096