Mention suggestion #13695

zombieJ · 2018-12-18T11:53:23Z

Currently suggestions of Mention is fully controlled. Add defaultSuggestions to support user input filter.

ref: #13678

netlify · 2018-12-18T12:01:13Z

Deploy preview for ant-design ready!

Built with commit 0ff68c6

https://deploy-preview-13695--ant-design.netlify.com

codecov · 2018-12-18T12:03:49Z

Codecov Report

Merging #13695 into feature will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           feature   #13695      +/-   ##
===========================================
- Coverage    94.04%   93.99%   -0.05%     
===========================================
  Files          314      314              
  Lines         6951     6948       -3     
  Branches      1732     1732              
===========================================
- Hits          6537     6531       -6     
- Misses         400      403       +3     
  Partials        14       14

Impacted Files	Coverage Δ
components/mention/index.tsx	`88.46% <100%> (-0.63%)`	⬇️
components/_util/wave.tsx	`84.84% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d05ced...0ff68c6. Read the comment docs.

codecov · 2018-12-18T12:03:49Z

Codecov Report

Merging #13695 into feature will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           feature   #13695      +/-   ##
===========================================
- Coverage    94.04%   93.99%   -0.05%     
===========================================
  Files          314      314              
  Lines         6951     6948       -3     
  Branches      1732     1732              
===========================================
- Hits          6537     6531       -6     
- Misses         400      403       +3     
  Partials        14       14

Impacted Files	Coverage Δ
components/mention/index.tsx	`88.46% <100%> (-0.63%)`	⬇️
components/_util/wave.tsx	`84.84% <0%> (-3.04%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d05ced...0ff68c6. Read the comment docs.

afc163 · 2018-12-18T12:53:44Z

components/mention/demo/basic.md

@@ -31,7 +31,7 @@ ReactDOM.render(
    style={{ width: '100%' }}
    onChange={onChange}
    defaultValue={toContentState('@afc163')}
-    suggestions={['afc163', 'benjycui', 'yiminghe', 'RaoHai', '中文', 'にほんご']}
+    defaultSuggestions={['afc163', 'benjycui', 'yiminghe', 'RaoHai', '中文', 'にほんご']}


感觉应该加到 rc 里面

rc 的 suggestions 不支持 filter 是纯受控的，这个半受控是 antd 里加出来的。

zombieJ added 3 commits December 18, 2018 19:22

mention add defaultSuggestion

3e16d88

add test case

763c0ef

update doc

0ff68c6

zombieJ requested a review from afc163 December 18, 2018 11:57

afc163 reviewed Dec 18, 2018

View reviewed changes

afc163 merged commit d2c9e6b into feature Dec 20, 2018

afc163 deleted the mentionSuggestion branch December 20, 2018 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mention suggestion #13695

Mention suggestion #13695

zombieJ commented Dec 18, 2018

netlify bot commented Dec 18, 2018

codecov bot commented Dec 18, 2018

codecov bot commented Dec 18, 2018 •

edited

Loading

afc163 Dec 18, 2018

zombieJ Dec 18, 2018

Mention suggestion #13695

Mention suggestion #13695

Conversation

zombieJ commented Dec 18, 2018

netlify bot commented Dec 18, 2018

codecov bot commented Dec 18, 2018

Codecov Report

codecov bot commented Dec 18, 2018 • edited Loading

Codecov Report

afc163 Dec 18, 2018

Choose a reason for hiding this comment

zombieJ Dec 18, 2018

Choose a reason for hiding this comment

codecov bot commented Dec 18, 2018 •

edited

Loading