Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add @radio-button-checked-bg #15541

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

willc001
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.
    My company are theming ng-zorro-antd.

  2. Describe the problem and the scenario.
    It turns out some style declarations should be extracted to less variables for theming convenience.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 20, 2019

Deploy preview for ant-design ready!

Built with commit 57c20e3

https://deploy-preview-15541--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #15541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15541   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files         250      250           
  Lines        6653     6653           
  Branches     1914     1914           
=======================================
  Hits         6277     6277           
  Misses        375      375           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e395f3...57c20e3. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Mar 20, 2019

Maybe change .@{radio-group-prefix-cls}-solid background color instead?
Since we have provided the solid radio: https://ant.design/components/radio-cn/#components-radio-demo-radiobutton-solid

@@ -191,6 +191,7 @@

// Radio buttons
@radio-button-bg: @btn-default-bg;
@radio-button-checked-bg: @btn-default-bg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radio-button-bg is what you wanted.

@afc163
Copy link
Member

afc163 commented Mar 22, 2019

I believe @radio-button-bg is what you wanted, no need to change it's name.

@afc163 afc163 closed this Mar 22, 2019
@willc001
Copy link
Contributor Author

I'm sorry for not explaining clearly. @radio-button-bg does change the background color of selected radio button. But it will also change the background color of unselected radio buttons and normal radios, which is not expected. @afc163

Expected:

image

Actually:

image

@afc163 afc163 reopened this Mar 26, 2019
@afc163
Copy link
Member

afc163 commented Mar 26, 2019

@willc001 Thx for explaination, PR is accepted.

@afc163 afc163 merged commit f4a92d0 into ant-design:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants