-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add @radio-button-checked-bg #15541
refactor: add @radio-button-checked-bg #15541
Conversation
Deploy preview for ant-design ready! Built with commit 57c20e3 |
Codecov Report
@@ Coverage Diff @@
## master #15541 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 250 250
Lines 6653 6653
Branches 1914 1914
=======================================
Hits 6277 6277
Misses 375 375
Partials 1 1 Continue to review full report at Codecov.
|
Maybe change |
@@ -191,6 +191,7 @@ | |||
|
|||
// Radio buttons | |||
@radio-button-bg: @btn-default-bg; | |||
@radio-button-checked-bg: @btn-default-bg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radio-button-bg
is what you wanted.
I believe @radio-button-bg is what you wanted, no need to change it's name. |
I'm sorry for not explaining clearly. Expected: Actually: |
@willc001 Thx for explaination, PR is accepted. |
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Describe the source of requirement, like related issue link.
My company are theming ng-zorro-antd.
Describe the problem and the scenario.
It turns out some style declarations should be extracted to less variables for theming convenience.
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
English description
Chinese description (optional)
☑️ Self Check before Merge