Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name prop for checkbox group #15753

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Conversation

ztplz
Copy link
Contributor

@ztplz ztplz commented Mar 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.
    Support name attribute for Checkbox and Checkbox.Group #15751

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ztplz ztplz requested review from afc163 and zombieJ March 30, 2019 02:38
@netlify
Copy link

netlify bot commented Mar 30, 2019

Deploy preview for ant-design ready!

Built with commit e2b4c1d4657ad457ca36ce85a53d34fdadaef1c6

https://deploy-preview-15753--ant-design.netlify.com

@netlify
Copy link

netlify bot commented Mar 30, 2019

Deploy preview for ant-design ready!

Built with commit 2a875ee

https://deploy-preview-15753--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #15753 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15753      +/-   ##
==========================================
- Coverage   95.09%   95.05%   -0.05%     
==========================================
  Files         250      250              
  Lines        6647     6647              
  Branches     1930     1942      +12     
==========================================
- Hits         6321     6318       -3     
- Misses        325      328       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/checkbox/Group.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c1be3...2a875ee. Read the comment docs.

@afc163 afc163 merged commit ddf9dd5 into ant-design:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants