-
-
Notifications
You must be signed in to change notification settings - Fork 50.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add visible to filterDropdown function #17614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
sedx
changed the title
Add visible to filterDropdown function
feat: Add visible to filterDropdown function
Jul 15, 2019
# Conflicts: # components/table/__tests__/Table.filter.test.js # components/table/filterDropdown.tsx
Deploy preview for ant-design ready! Built with commit 2012834 |
afc163
approved these changes
Sep 17, 2019
afc163
added a commit
that referenced
this pull request
Sep 17, 2019
14 tasks
afc163
added a commit
that referenced
this pull request
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
👻 What's the background?
In some cases in my project I need to get actual visibility status of table's filterDropdown component.
There are now easy way to get it, because it's render when table is mount and not only when column's filter shown.
So I need to use something to like this (ugly and markup dependent 🤦♂️):
To trigger focus when filterDropdown shown.
💡 Solution
Currently
FilterMenu
contains current visibility status, just pass it to filterDropdown.📝 Changelog
Add yet another attribute to call of filterDropdown, which contain result of
FilterMenu#getDropdownVisible()
callAlso update doc of filterDropdown prop. Now it contains info that filterDropdown can accept function (in previous doc revision was only ReactNode) and add link to ts defenition of arguments of this function.
☑️ Self Check before Merge
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md