Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Styling issue where all spans next to a checkbox wrapper get a padding #17752

Merged
merged 4 commits into from
Jul 20, 2019
Merged

Conversation

inovux
Copy link
Contributor

@inovux inovux commented Jul 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

closes #17714

💡 Background and solution

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 19, 2019

Deploy preview for ant-design ready!

Built with commit c5a9394

https://deploy-preview-17752--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #17752 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17752      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.04%     
==========================================
  Files         267      267              
  Lines        7443     7443              
  Branches     2038     2065      +27     
==========================================
+ Hits         7152     7155       +3     
+ Misses        289      286       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad39bb...11e0f53. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #17752 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17752      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.04%     
==========================================
  Files         267      267              
  Lines        7443     7443              
  Branches     2038     2038              
==========================================
+ Hits         7152     7155       +3     
+ Misses        289      286       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06eb86c...c5a9394. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jul 20, 2019

@inovux
Copy link
Contributor Author

inovux commented Jul 20, 2019

图片

It will break https://deploy-preview-17752--ant-design.netlify.com/components/table/#components-table-demo-reset-filter

Yep, you are right. I think it would be good to handle this particular case only instead of giving all spans after the .ant-checkbox-wrapper a padding.

What about giving the span in that table a class and only style it with extra padding when it's preceded by a checkbox?

@afc163
Copy link
Member

afc163 commented Jul 20, 2019

What about giving the span in that table a class and only style it with extra padding when it's preceded by a checkbox?

Fair enough, could you update your PR for this?

@afc163 afc163 merged commit 5a32990 into ant-design:master Jul 20, 2019
@inovux
Copy link
Contributor Author

inovux commented Jul 20, 2019

It automatically merged? I still wanted to add one more change.

@afc163
Copy link
Member

afc163 commented Jul 20, 2019

You can create another pull request.

@inovux
Copy link
Contributor Author

inovux commented Jul 20, 2019

You can create another pull request.

Ahh okay thanks, sorry im new to this. Like to learn from it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox and Input with prefix together will make a position bug.
2 participants