-
-
Notifications
You must be signed in to change notification settings - Fork 50.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Styling issue where all spans next to a checkbox wrapper get a padding #17752
Conversation
Deploy preview for ant-design ready! Built with commit c5a9394 |
Codecov Report
@@ Coverage Diff @@
## master #17752 +/- ##
==========================================
+ Coverage 96.09% 96.13% +0.04%
==========================================
Files 267 267
Lines 7443 7443
Branches 2038 2065 +27
==========================================
+ Hits 7152 7155 +3
+ Misses 289 286 -3
Partials 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17752 +/- ##
==========================================
+ Coverage 96.09% 96.13% +0.04%
==========================================
Files 267 267
Lines 7443 7443
Branches 2038 2038
==========================================
+ Hits 7152 7155 +3
+ Misses 289 286 -3
Partials 2 2
Continue to review full report at Codecov.
|
Yep, you are right. I think it would be good to handle this particular case only instead of giving all spans after the What about giving the span in that table a class and only style it with extra padding when it's preceded by a checkbox? |
Fair enough, could you update your PR for this? |
It automatically merged? I still wanted to add one more change. |
You can create another pull request. |
Ahh okay thanks, sorry im new to this. Like to learn from it :) |
🤔 This is a ...
🔗 Related issue link
closes #17714
💡 Background and solution
.ant-checkbox-wrapper + span
, since I don't see it being used anywhere. This style should be only available on the.ant-checkbox + span
class.☑️ Self Check before Merge