Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pagination itemRender disabled prop #21361

Merged
merged 1 commit into from
Feb 13, 2020
Merged

feat: Pagination itemRender disabled prop #21361

merged 1 commit into from
Feb 13, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 13, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #21351

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Pagination will pass disabled prop to prev/next buttons return by itemRender.
🇨🇳 Chinese Pagination 自定义 itemRender 返回的上一页下一页现在会补充 disabled 属性。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 13, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e554641:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #21361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21361   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        7003     7003           
  Branches     1932     1884   -48     
=======================================
  Hits         6832     6832           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef326b...e554641. Read the comment docs.

@afc163 afc163 merged commit 291ba0c into master Feb 13, 2020
@afc163 afc163 deleted the upgrade-pagination branch February 13, 2020 05:31
@pr-triage pr-triage bot added the PR: merged label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination custom prev next
2 participants