Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Badge with rc-motion #27848

Merged
merged 7 commits into from
Nov 18, 2020
Merged

refactor: Replace Badge with rc-motion #27848

merged 7 commits into from
Nov 18, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Replace Badge with rc-motion instead of rc-animate.
🇨🇳 Chinese 替换 Badge 所使用的 rc-animate 动画库为 rc-motion

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Nov 18, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 18, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2020

Size Change: -803 B (0%)

Total Size: 788 kB

Filename Size Change
./dist/antd-with-locales.min.js 312 kB -429 B (0%)
./dist/antd.compact.min.css 66.5 kB +23 B (0%)
./dist/antd.dark.min.css 67.8 kB +14 B (0%)
./dist/antd.min.css 66.5 kB +22 B (0%)
./dist/antd.min.js 276 kB -433 B (0%)

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0eafa2d:

Sandbox Source
antd reproduction template Configuration

@zombieJ zombieJ requested review from hengkx and afc163 and removed request for hengkx November 18, 2020 09:47
@zombieJ zombieJ marked this pull request as ready for review November 18, 2020 10:06
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #27848 (0eafa2d) into master (4703001) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7348      7331   -17     
  Branches      2091      2084    -7     
=========================================
- Hits          7348      7331   -17     
Impacted Files Coverage Δ
components/badge/ScrollNumber.tsx 100.00% <100.00%> (ø)
components/badge/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4703001...0eafa2d. Read the comment docs.

<CSSMotion
motionAppear={true}
motionName="ant-badge-zoom"
visible={true}
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也顺便改成 render snapshot 好了。

@zombieJ zombieJ merged commit 507b596 into master Nov 18, 2020
@zombieJ zombieJ deleted the rc-motion branch November 18, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants