Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: draggable Modal should have boundary #28527

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Conversation

mumiao
Copy link
Contributor

@mumiao mumiao commented Dec 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #28438

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/modal/demo/modal-render.md

@mumiao
Copy link
Contributor Author

mumiao commented Dec 24, 2020

@yoyo837 @afc163 那个pr分支混杂了别的commits 我重新提到这里来

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Dec 24, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 28ecd41:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2020

Size Change: -21 B (0%)

Total Size: 793 kB

Filename Size Change
./dist/antd.compact.min.css 66.7 kB -8 B (0%)
./dist/antd.dark.min.css 68 kB -5 B (0%)
./dist/antd.min.css 66.7 kB -8 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 314 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 24, 2020

窗口resize后,依然可以拖拽到外面

@afc163 afc163 changed the title fix: draggle handler not allowed outside of screen fix: draggable Modal should have boundary Dec 24, 2020
@mumiao
Copy link
Contributor Author

mumiao commented Dec 25, 2020

窗口resize后,依然可以拖拽到外面

done

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 25, 2020

@xrkffgg 这个CI failed和 改动的action 有关系不?

@xrkffgg
Copy link
Member

xrkffgg commented Dec 25, 2020

@xrkffgg 这个CI failed和 改动的action 有关系不?

没关系

@mumiao
Copy link
Contributor Author

mumiao commented Dec 27, 2020

@afc163 @yoyo837 CI 报错跟我此次提交没有关系。 review一下看看?

@afc163 afc163 merged commit 7ae07c1 into ant-design:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modal] 自定义渲染对话框 Draggable 文档应当优化为只在 body 内可拖拽
5 participants