Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal footer buttons not spaced when using href in button #29681

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

headwindz
Copy link
Contributor

@headwindz headwindz commented Mar 9, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #29658

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the bug that Modal footer buttons not spaced properly when using href in button.
🇨🇳 Chinese 修复Modal页脚里使用href按钮导致的间距丢失问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #29681 (8f79e7e) into master (280201a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #29681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          394       394           
  Lines         7519      7519           
  Branches      2111      2111           
=========================================
  Hits          7519      7519           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280201a...63a675c. Read the comment docs.

@xrkffgg
Copy link
Member

xrkffgg commented Mar 9, 2021

close https://github.com/ant-design/ant-design/issues/29658

or fix or resolve

PR 里用这种方式

@xrkffgg xrkffgg merged commit f465589 into ant-design:master Mar 9, 2021
@tqwewe
Copy link

tqwewe commented Mar 9, 2021

@xrkffgg Thank you for resolving this so fast.

@headwindz headwindz deleted the modal-footer-btns branch March 9, 2021 13:19
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal footer buttons not spaced when using href in button
3 participants