Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "tooltipProps" prop to slider props #33307

Closed
wants to merge 2 commits into from

Conversation

MorisR
Copy link

@MorisR MorisR commented Dec 15, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#33298
#18016

💡 Background and solution

Explained in the issues above

📝 Changelog

Add "tooltipProps" prop to "slider" component.

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

Prepare preview

@MorisR
Copy link
Author

MorisR commented Dec 15, 2021

@afc163 can you approve/review?

@afc163
Copy link
Member

afc163 commented Dec 15, 2021

Please add a test case.

@MorisR
Copy link
Author

MorisR commented Dec 15, 2021

@afc163 good enough?

@MorisR MorisR changed the title featute: Add "tooltipProps" prop to slider props feat: Add "tooltipProps" prop to slider props Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #33307 (1bf1f41) into feature (396cfab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #33307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          417       417           
  Lines         7771      7773    +2     
  Branches      2192      2193    +1     
=========================================
+ Hits          7771      7773    +2     
Impacted Files Coverage Δ
components/slider/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6946f0b...1bf1f41. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 22, 2021

We need to deprecate tooltipPlacement and tooltipVisible too.

Maybe rename tooltipProps to tooltip.

@afc163
Copy link
Member

afc163 commented Jan 7, 2022

ping @MorisR

@MorisR
Copy link
Author

MorisR commented Jan 7, 2022

I'll do it, just need more time, work and all + holidays

@afc163
Copy link
Member

afc163 commented Mar 30, 2022

ping @MorisR

@MorisR
Copy link
Author

MorisR commented Mar 30, 2022

I know.. I know...
I'll get to it when/if I can..
Believe me.. didn't have ANY free time on my hands lately...
From working 14 hours a day to trying to maintain/squeeze in some personal time

@afc163
Copy link
Member

afc163 commented Aug 30, 2022

Supported in #37043

@afc163 afc163 closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants