Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use before to avoid conflict with primary basic animation effect #39241

Conversation

foryuki
Copy link
Contributor

@foryuki foryuki commented Dec 4, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before

Screen.Recording.2022-12-04.at.16.29.54.mov

After

Screen.Recording.2022-12-04.at.16.28.23.mov

📝 Changelog

Language Changelog
🇺🇸 English use :before to avoid conflict with primary basic animation effect
🇨🇳 Chinese 使用 :before 避免与 primary button 点击动画样式冲突

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

@foryuki foryuki marked this pull request as ready for review December 4, 2022 08:39
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (545dcb1) compared to base (fbab5df).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9364      9364           
  Branches      2653      2653           
=========================================
  Hits          9364      9364           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vagusX vagusX requested a review from zombieJ December 5, 2022 08:38
@zombieJ zombieJ merged commit 8afc844 into ant-design:master Dec 5, 2022
@zombieJ zombieJ mentioned this pull request Dec 8, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants