Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table scroll shadow in rtl mode #40441

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

ds1371dani
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Table's vertical shadow in rtl mode is on the wrong side of the table.

image

📝 Changelog

Language Changelog
🇺🇸 English 💄 Fix Table scroll shadow in rtl mode.
🇨🇳 Chinese 💄 在 rtl 模式下修复 Table 滚动阴影.

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2023

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (00e3bb5) compared to base (45b65f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #40441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          605       605           
  Lines        10306     10306           
  Branches      2774      2774           
=========================================
  Hits         10306     10306           
Impacted Files Coverage Δ
components/table/style/rtl.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 29, 2023

CI failed.

@afc163 afc163 changed the title FIX Table scroll shadow in rtl mode fix: Table scroll shadow in rtl mode Jan 29, 2023
@afc163 afc163 merged commit cac6d5c into ant-design:master Jan 29, 2023
@PeachScript PeachScript mentioned this pull request Jan 31, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode

* Revert "💄 STYLE: fix Table's scroll shadow in rtl mode"

This reverts commit 06c9249.

* 💄 STYLE: use logical properties
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode

* Revert "💄 STYLE: fix Table's scroll shadow in rtl mode"

This reverts commit 06c9249.

* 💄 STYLE: use logical properties
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* 💄 STYLE: fix Table's scroll shadow in rtl mode

* Revert "💄 STYLE: fix Table's scroll shadow in rtl mode"

This reverts commit 06c9249.

* 💄 STYLE: use logical properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants