Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename preset colors in token #41071

Merged
merged 2 commits into from
Mar 5, 2023
Merged

refactor: rename preset colors in token #41071

merged 2 commits into from
Mar 5, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Mar 5, 2023

  • refactor: rename preset colors in Design Token
  • feat: rename preset color in token

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Rename preset colors in token, .e.g blue-1 to blue1, and deprecate tokens before.
🇨🇳 Chinese 重命名 token 中的预设颜色,如 blue-1 变为 blue1,废弃原有的 token。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.35 KB (+9 B 🔺)
./dist/antd-with-locales.min.js 431.29 KB (+10 B 🔺)

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (8ae56f2) 100.00% compared to head (fae1fcb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41071   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          608       608           
  Lines        10404     10406    +2     
  Branches      2831      2831           
=========================================
+ Hits         10404     10406    +2     
Impacted Files Coverage Δ
components/theme/interface/presetColors.ts 100.00% <ø> (ø)
components/style/presetColor.tsx 100.00% <100.00%> (ø)
components/theme/themes/dark/index.ts 100.00% <100.00%> (ø)
components/theme/themes/default/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 8467428 into master Mar 5, 2023
@MadCcc MadCcc deleted the feat/color-token branch March 5, 2023 12:49
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* refactor: rename preset colors in Design Token

* feat: rename preset color in token
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* refactor: rename preset colors in Design Token

* feat: rename preset color in token
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* refactor: rename preset colors in Design Token

* feat: rename preset color in token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants