fix(form): success feedback should display when pass hasFeedback prop and current value is valid value #41116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #41116 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 610 611 +1
Lines 10438 10597 +159
Branches 2842 2891 +49
==========================================
+ Hits 10438 10597 +159
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zombieJ
reviewed
Mar 8, 2023
zombieJ
reviewed
Mar 9, 2023
zombieJ
approved these changes
Mar 9, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
… and current value is valid value (ant-design#41116) * fix: success feedback should display when pass hasFeedback prop and type valid value * feat: optimize code * feat: update test case * feat: optimize code * feat: optimize code * feat: update demo * feat: update test case * feat: update demo * feat: update test case * feat: reset demo
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
… and current value is valid value (ant-design#41116) * fix: success feedback should display when pass hasFeedback prop and type valid value * feat: optimize code * feat: update test case * feat: optimize code * feat: optimize code * feat: update demo * feat: update test case * feat: update demo * feat: update test case * feat: reset demo
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
… and current value is valid value (ant-design#41116) * fix: success feedback should display when pass hasFeedback prop and type valid value * feat: optimize code * feat: update test case * feat: optimize code * feat: optimize code * feat: update demo * feat: update test case * feat: update demo * feat: update test case * feat: reset demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
hasFeedback属性且当前值是合法值时应展示成功反馈☑️ Self-Check before Merge