Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: remove tag border in Select、Tree-select、Cascader #41480

Merged
merged 26 commits into from
Apr 7, 2023
Merged

✨ feat: remove tag border in Select、Tree-select、Cascader #41480

merged 26 commits into from
Apr 7, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Mar 27, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

设计有需求把 Select、Tree-select、Cascader 的多选 Tag 替换为无边框的。
同时因为样式和 antd 的 Tag 基本一致，所以尝试下直接替换，从设计角度上可以保证一致性，antd 侧也可以少加点样式。

📝 Changelog

Language Changelog
🇺🇸 English feat: remove tag border in Select、Tree-select、Cascader
🇨🇳 Chinese feat: 调整 Select、Tree-select、Cascader 多选模式的标签样式，去除标签的边框

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 375.79 KB (-21 B 🔽)
./dist/antd-with-locales.min.js 434.55 KB (-26 B 🔽)

@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (851d551) 100.00% compared to head (18a267f) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #41480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          614       614           
  Lines        10503     10505    +2     
  Branches      2877      2877           
=========================================
+ Hits         10503     10505    +2
Impacted Files Coverage Δ
components/tree-select/index.tsx 100.00% <ø> (ø)
components/select/style/multiple.tsx 100.00% <100.00%> (ø)
components/tree-select/style/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan requested a review from MadCcc March 27, 2023 14:44
@li-jia-nan li-jia-nan changed the title ✨ feat: default use tag in select ✨ feat: default use Tag in select Mar 27, 2023
@li-jia-nan li-jia-nan changed the title ✨ feat: default use Tag in select ✨ feat: default use tag in select Mar 27, 2023
@afc163
Copy link
Member

afc163 commented Mar 28, 2023

原始问题和需求是什么？

@li-jia-nan
Copy link
Member Author

原始问题和需求是什么？

image

@MadCcc
Copy link
Member

MadCcc commented Mar 28, 2023 •
edited
Loading

原始问题和需求是什么？

设计有需求把 Select 的多选 Tag 替换为无边框的。
同时因为样式和 antd 的 Tag 基本一致，所以尝试下直接替换，从设计角度上可以保证一致性，antd 侧也可以少加点样式。

@afc163
Copy link
Member

afc163 commented Apr 2, 2023

图片

关闭图标和文字都有点偏下？

@li-jia-nan
Copy link
Member Author

li-jia-nan commented Apr 2, 2023 •
edited
Loading

关闭图标和文字都有点偏下？

这个先等一下，闲夕大佬说对 <Tag /> 组件魔改太复杂的话不如直接写个 <span /> 标签了，他还要和设计师沟通一下，这个我先转 draft 状态了

@li-jia-nan li-jia-nan marked this pull request as draft April 2, 2023 08:08
@li-jia-nan li-jia-nan marked this pull request as ready for review April 4, 2023 04:22
@li-jia-nan li-jia-nan changed the title ✨ feat: default use tag in select and tree-select style: delete tag border in select and tree-select Apr 4, 2023
@li-jia-nan li-jia-nan changed the title style: delete tag border in select and tree-select style: remove tag border in select and tree-select Apr 4, 2023
@li-jia-nan li-jia-nan changed the title style: remove tag border in select and tree-select ✨ feat: remove tag border in select and tree-select Apr 4, 2023
@li-jia-nan @MadCcc
Update components/select/style/multiple.tsx
18a267f 
Co-authored-by: MadCcc <1075746765@qq.com>
@li-jia-nan li-jia-nan requested a review from MadCcc April 6, 2023 13:23
@MadCcc MadCcc merged commit 3c3cda0 into feature Apr 7, 2023
@MadCcc MadCcc deleted the border branch April 7, 2023 02:18
@li-jia-nan li-jia-nan changed the title ✨ feat: remove tag border in select and tree-select ✨ feat: remove tag border in Select、Tree-select、Cascader Apr 11, 2023
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@li-jia-nan @MadCcc @RedJue
✨ feat: remove tag border in select and tree-select (ant-design#41480)
3564325 
* ✨ feat: new tag

* update demo

* update snap

* fix

* fix

* fix

* fix

* fix

* fix

* fix style

* update snap

* revert

* fix

* fix

* fix

* fix

* fix

* Update components/select/style/multiple.tsx

Co-authored-by: MadCcc <1075746765@qq.com>

---------

Co-authored-by: MadCcc <1075746765@qq.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
@li-jia-nan @MadCcc @RedJue
✨ feat: remove tag border in select and tree-select (ant-design#41480)
12ad0d7 
* ✨ feat: new tag

* update demo

* update snap

* fix

* fix

* fix

* fix

* fix

* fix

* fix style

* update snap

* revert

* fix

* fix

* fix

* fix

* fix

* Update components/select/style/multiple.tsx

Co-authored-by: MadCcc <1075746765@qq.com>

---------

Co-authored-by: MadCcc <1075746765@qq.com>
@MadCcc MadCcc mentioned this pull request May 4, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@li-jia-nan @afc163 @MadCcc