Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): migrate less to token #42938

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jun 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English migrate less to token for
🇨🇳 Chinese 迁移 less token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5d7c6ab

This pull request introduces a new feature that allows users to customize the header padding of the Collapse component by using a component token function. It also updates the documentation and the demo page for this feature in both Chinese and English languages. It modifies the files components/collapse/style/index.ts, components/collapse/demo/component-token.md, components/collapse/demo/component-token.tsx, components/collapse/index.en-US.md, components/collapse/index.zh-CN.md, and docs/react/migrate-less-variables.zh-CN.md.

🔍 Walkthrough

🤖 Generated by Copilot at 5d7c6ab

  • Add a demo page for the component token feature of the collapse component (link, link, link, link)
  • Modify the component token interface and the collapse token type to include the headerPadding property (link)
  • Use the headerPadding property from the component token to generate the base style of the collapse component (link)
  • Use the paddingContentHorizontal property from the token to generate the base style of the collapse component (link)
  • Accept a component token function as the third argument of the default export function in components/collapse/style/index.ts and remove the collapseHeaderPadding and collapseContentPaddingHorizontal properties from the collapse token (link)
  • Update the table of the mapping between the less variables and the component token for the collapse component in the Chinese documentation of the migrate less variables page (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Prepare preview

@Wxh16144 Wxh16144 mentioned this pull request Jun 9, 2023
51 tasks
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (db07a2f) 100.00% compared to head (64a7468) 100.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42938   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11271     11267    -4     
  Branches      3047      3047           
=========================================
- Hits         11271     11267    -4     
Files Changed Coverage Δ
components/collapse/style/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@argos-ci
Copy link

argos-ci bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 3 changes Aug 14, 2023, 9:59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants