Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Radio.Button title loss #43012

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Jun 14, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#43008

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Radio.Button title loss,update typescript definition
🇨🇳 Chinese 修复单选按钮 title 属性不生效,补齐 ts

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 418a4a2

Added a title prop to the Checkbox and Radio components and their documentation files. This prop allows setting a custom tooltip for the checkbox or radio button, using the native HTML title attribute. Updated the documentation in both English and Chinese with version and title information for the new prop.

🔍 Walkthrough

🤖 Generated by Copilot at 418a4a2

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

components/radio/radio.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jun 14, 2023

如果 title 已经传给过 https://github.com/react-component/checkbox/ ,是否应该修改 rc-checkbox 看看 title 为啥没挂上?

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b72d313) 100.00% compared to head (218defe) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43012   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10953     10953           
  Branches      2972      2972           
=========================================
  Hits         10953     10953           
Impacted Files Coverage Δ
components/checkbox/Checkbox.tsx 100.00% <ø> (ø)
components/checkbox/Group.tsx 100.00% <ø> (ø)
components/radio/group.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@linxianxi
Copy link
Contributor Author

如果 title 已经传给过 https://github.com/react-component/checkbox/ ,是否应该修改 rc-checkbox 看看 title 为啥没挂上?

同上 #43012 (comment)

@afc163
Copy link
Member

afc163 commented Jun 14, 2023

@linxianxi linxianxi changed the base branch from feature to master June 15, 2023 00:37
@linxianxi linxianxi requested a review from afc163 June 15, 2023 00:45
@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
rc-checkbox 🆕 3.1.0 None +0 20.6 kB afc163

Footnotes

  1. https://docs.socket.dev

@linxianxi linxianxi changed the title feat: Radio、Checkbox title fix: Radio.Button title loss Jun 15, 2023
@afc163 afc163 merged commit e9bbc58 into ant-design:master Jun 15, 2023
@zombieJ zombieJ mentioned this pull request Jun 19, 2023
16 tasks
BoyYangzai pushed a commit to BoyYangzai/ant-design that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants