-
-
Notifications
You must be signed in to change notification settings - Fork 51k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AutoComplete): AutoComplete support rootClassName #44055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44055 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 658 658
Lines 11166 11368 +202
Branches 3024 3099 +75
==========================================
+ Hits 11166 11368 +202
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Aug 7, 2023
kiner-tang
commented
Aug 7, 2023
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
kiner-tang
commented
Aug 7, 2023
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
kiner-tang
commented
Aug 7, 2023
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
zombieJ
reviewed
Aug 7, 2023
zombieJ
reviewed
Aug 7, 2023
zombieJ
approved these changes
Aug 8, 2023
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 7ba2971
This pull request adds a new prop
rootClassName
to theAutoComplete
component, which enables users to customize the class name of the popup element. It also updates the tests, demos and documentation to reflect the new prop.🔍 Walkthrough
🤖 Generated by Copilot at 7ba2971
rootClassName
prop toAutoComplete
component to allow customizing the root element and the popup element of the component (link, link, link)AutoComplete
component in both English and Chinese to include therootClassName
prop and its details (link, link)rootClassName
prop to the basic demo of theAutoComplete
component to show its usage and effect (link)rootClassName
prop of theAutoComplete
component to verify that the custom root class name is applied to the element (link)