-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: input token #44325
Merged
Merged
feat: input token #44325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
li-jia-nan
approved these changes
Aug 21, 2023
size-limit report 📦
|
51 tasks
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11285 11287 +2
Branches 3049 3049
=========================================
+ Hits 11285 11287 +2
☔ View full report in Codecov by Sentry. |
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 161b037
The pull request refactors the style modules of several input-related components (
Input
,InputNumber
,Mentions
, andPagination
) to use the new shared component tokens and input tokens, which provide more consistent and customizable style properties. The pull request also updates the theme interface and the migration documents to reflect the changes in theInput
component style tokens.🔍 Walkthrough
🤖 Generated by Copilot at 161b037
Input
component to use the newSharedComponentToken
andSharedInputToken
types for common properties of input components (link,link,link,link,link,link,link,link,link,link,link,link)InputNumber
component to extend theSharedComponentToken
andSharedInputToken
types and add new token properties for the handle buttons (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)Mentions
component to extend theSharedComponentToken
andSharedInputToken
types and use the new token properties for padding (link,link,link,link,link,link,link)Pagination
component to extend theSharedComponentToken
andSharedInputToken
types (link,link,link)ComponentTokenMap
interface to include theInputComponentToken
type (link,link)initInputToken
import from thetypography/style/mixins.ts
file and use the global token property for padding (link,link)Input
component in themigrate-less-variables.en-US.md
andmigrate-less-variables.zh-CN.md
documents, to list the mapping of the less variables to the component tokens and the notes for the migration (link,link)