Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add itemSelectedFontColor token in Segemented Component #44570

Merged
merged 3 commits into from
Sep 4, 2023
Merged

feature: add itemSelectedFontColor token in Segemented Component #44570

merged 3 commits into from
Sep 4, 2023

Conversation

xiaozisong
Copy link
Contributor

@xiaozisong xiaozisong commented Sep 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44513

💡 Background and solution

📝 Changelog

  • 新增itemSelectedFontColor的token,默认与itemColor的token相同,可以自定义item被选中时的颜色
Language Changelog
🇺🇸 English add itemSelectedColor token in Segemented Component
🇨🇳 Chinese Segmented 组件新增 itemSelectedColor 的组件 Token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5318af6

This pull request enhances the segmented component by adding a new style property itemSelectedFontColor that can be used to customize the text color of the selected item. It also updates the style file and the demo file to demonstrate this feature.

🔍 Walkthrough

🤖 Generated by Copilot at 5318af6

  • Add a new property itemSelectedFontColor to the custom token of the segmented component to customize the text color of the selected item (link, link, link)
  • Use the new property itemSelectedFontColor instead of the existing property itemHoverColor for the color of the selected item in the genSegmentedStyle function in components/segmented/style/index.tsx (link)
  • Add a console log statement to the genSegmentedStyle function for debugging purposes (link)

@stackblitz
Copy link

stackblitz bot commented Sep 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 19 changes Sep 4, 2023, 2:30 AM

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b12d69c) 100.00% compared to head (75253c5) 100.00%.
Report is 20 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44570   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          678       678           
  Lines        11425     11429    +4     
  Branches      3078      3080    +2     
=========================================
+ Hits         11425     11429    +4     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MadCcc <1075746765@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants