fix: checkbox ref type #44746
Merged
fix: checkbox ref type #44746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
yoyo837
approved these changes
Sep 11, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44746 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 680 681 +1
Lines 11427 11526 +99
Branches 3073 3103 +30
=========================================
+ Hits 11427 11526 +99
☔ View full report in Codecov by Sentry. |
|
ci broken |
Thanks, will address the lint changes
And for the screenhshot test, are you sure this test isn`t flaky? Is it possible to run this again? |
afc163
reviewed
Sep 12, 2023
| @@ -1,10 +1,10 @@ | |||
| import * as React from 'react'; | |||
| import Checkbox from '..'; | |||
| import Checkbox, { CheckboxRef } from '..'; | |||
There was a problem hiding this comment.
Import "CheckboxRef" is only used as types. (@typescript-eslint/consistent-type-imports)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link #44725
💡 Background and solution
To reproduce please check related issue link
Changed
HTMLInputElementtoCheckboxRefso for external usage for now checkbox should have a properly defined type📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at db4fb7b
Updated
CheckboxReftype import and export to matchrc-checkboxdependency and moved them to the top ofcomponents/checkbox/index.ts. This improves type compatibility and code organization.🔍 Walkthrough
🤖 Generated by Copilot at db4fb7b
CheckboxReftype to match the upstream changes inrc-checkbox(link)