Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: add border for demo #45342

Merged
merged 2 commits into from
Oct 14, 2023
Merged

demo: add border for demo #45342

merged 2 commits into from
Oct 14, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Oct 14, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

before:

image

after:

image

📝 Changelog

Language Changelog
🇺🇸 English demo: update demo
🇨🇳 Chinese -

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b992591

Updated the style of the container div in components/affix/demo/target.tsx to make the demo look more consistent with the Affix component.

🔍 Walkthrough

🤖 Generated by Copilot at b992591

  • Added a target prop to the Affix component to allow specifying a custom scroll container ( )

@stackblitz
Copy link

stackblitz bot commented Oct 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023

Preview Is ready

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 397.92 KB
./dist/antd-with-locales.min.js 457.23 KB

@argos-ci
Copy link

argos-ci bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Oct 14, 2023, 3:43 AM

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73c0cd7) 100.00% compared to head (b992591) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45342   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          692       692           
  Lines        11672     11672           
  Branches      3117      3117           
=========================================
  Hits         11672     11672           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 406817a into master Oct 14, 2023
99 checks passed
@li-jia-nan li-jia-nan deleted the demo-up branch October 14, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants