fix: Fixed image preview in a nested pop-up where z-index Settings did not meet expectations #45979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not meet expectations
|
|
|
|
yoyo837
approved these changes
Nov 21, 2023
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29db8b6:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45979 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 700 700
Lines 11849 11851 +2
Branches 3158 3159 +1
=========================================
+ Hits 11849 11851 +2 ☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #45975
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖[deprecated] Generated by Copilot at d93d306
Added z-index management for the
Imagecomponent with a preview feature. Used theuseZIndexhook to assign z-index values to the image preview elements and updated therc-imagedependency to support thezIndexprop. Added a test case for theuseZIndexhook with theImagecomponent.🔍 Walkthrough
🤖[deprecated] Generated by Copilot at d93d306
rc-imagedependency to use the latest version that supports thezIndexprop for thePreviewGroupcomponent (link)useZIndexhook inImagecomponent to get the z-index value for the preview element based on theImagePreviewconsumer and the optionalzIndexprop from thepreviewobject (link, link, link)PreviewGroupcomponent as a prop to set the z-index of the preview element (link)ZIndexConsumertype andconsumerBaseZIndexOffsetobject to include theImagePreviewconsumer and assign a base z-index offset value of 1 to it (link, link)ImagePreviewcomponent to theuseZIndextest file and importImagecomponent andImagePropstype fromantdto use them in theImagePreviewcomponent (link, link, link)getConsumerSelectorfunction in theuseZIndextest file to handle theImagePreviewconsumer case and return the appropriate selector for the preview element based on the root class name (link)