Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line Progress gradient should be full width #46209

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46149

before:
image

After:
image

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Progress that gradient in line should follow percent.
🇨🇳 Chinese 修复 Progress 进度条视觉效果,渐变效果应该随着百分比改变。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Preview Is ready

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 1, 2023

由浅入深会不会好看点

Copy link
Contributor

github-actions bot commented Dec 1, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 324.7 KB (-22 B 🔽)
./dist/antd-with-locales.min.js 370.51 KB (-201 B 🔽)

@MadCcc
Copy link
Member Author

MadCcc commented Dec 1, 2023

由浅入深会不会好看点

这个用户自己可以改哈,不是内置的

Copy link

codesandbox-ci bot commented Dec 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5765f1a:

Sandbox Source
antd reproduction template (forked) Configuration

@MadCcc
Copy link
Member Author

MadCcc commented Dec 1, 2023

chrome 对 clip-path 的实现可能有点问题,看起来会有点歪。safari 和 firefox 下正常

chorme:
image

firefox:
image

safari:
image

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38c941e) 100.00% compared to head (5765f1a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46209   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        11874     11879    +5     
  Branches      3161      3165    +4     
=========================================
+ Hits         11874     11879    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 77d1328 into master Dec 1, 2023
103 checks passed
@MadCcc MadCcc deleted the fix/line-progres branch December 1, 2023 08:48
Copy link
Contributor

github-actions bot commented Dec 1, 2023

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@vagusX vagusX mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

线性进度条<Progress>组件 能否和圆形进度条一样支持锥形渐变?
3 participants