Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload.Dragger not align center #46810

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 5, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46795

💡 Background and solution

#46432 里改成 display: flex; 是为了让 focus 的 outline 样式有圆角,这个后面再想办法。

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload.Dragger not align center and focus ring style.
🇨🇳 Chinese 修复 Upload.Dragger 内容不居中和多余的 focus 样式的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Visual Regression Report for PR #46810 Failed ❌

Target branch: master (9ece76b)
View Full Report


image name expected actual diff
form-validate-other.png master: 9ece76b269f7608cbdf4323a660f99dd3ae10242 current: pr-46810 diff
form-validate-other.css-var.png master: 9ece76b269f7608cbdf4323a660f99dd3ae10242 current: pr-46810 diff
upload-drag.png master: 9ece76b269f7608cbdf4323a660f99dd3ae10242 current: pr-46810 diff
upload-drag.css-var.png master: 9ece76b269f7608cbdf4323a660f99dd3ae10242 current: pr-46810 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 5, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 328.97 KB (+3 B 🔺)
./dist/antd-with-locales.min.js 375.04 KB (+12 B 🔺)

Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d78cdd9:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ece76b) 100.00% compared to head (d78cdd9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          722       722           
  Lines        12443     12443           
  Branches      3265      3265           
=========================================
  Hits         12443     12443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 1532498 into master Jan 5, 2024
115 of 116 checks passed
@afc163 afc163 deleted the fix/upload-dragger-style branch January 5, 2024 06:22
Copy link
Contributor

github-actions bot commented Jan 5, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@yoyo837
Copy link
Contributor

yoyo837 commented Jan 5, 2024

我放个与上上次的差异图

image

@yoyo837 yoyo837 mentioned this pull request Jan 5, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.12.7版本中 Upload.Dragger的children节点无法获取父节点的Size
3 participants